Sign upLogin

cea-sec/miasm

View on GitHub
Star
miasm/expression/simplifications_explicit.py

Summary

Maintainability
D
2 days
Test Coverage

Function simp_flags has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
Open

def simp_flags(_, expr):
    args = expr.args

    if expr.is_op("FLAG_EQ"):
        return ExprCond(args[0], ExprInt(0, 1), ExprInt(1, 1))
Severity: Minor
Found in miasm/expression/simplifications_explicit.py - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

        return (op1 + op2 + op3.zeroExtend(op1.size)).msb()
Severity: Major
Found in miasm/expression/simplifications_explicit.py - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

            return (((op1 ^ op2) ^ res) ^ ((op1 ^ res) & (op1 ^ op2))).msb()
    Severity: Major
    Found in miasm/expression/simplifications_explicit.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

              return (((op1 ^ res) & (op1 ^ op2))).msb()
      Severity: Major
      Found in miasm/expression/simplifications_explicit.py - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                return ExprCond(
        Severity: Major
        Found in miasm/expression/simplifications_explicit.py - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                  return (((op1 ^ res) & (op1 ^ op2))).msb()
          Severity: Major
          Found in miasm/expression/simplifications_explicit.py - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                    return (((op1 ^ res) & (~(op1 ^ op2)))).msb()
            Severity: Major
            Found in miasm/expression/simplifications_explicit.py - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                      return (((op1 ^ res) & (~(op1 ^ op2)))).msb()
              Severity: Major
              Found in miasm/expression/simplifications_explicit.py - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                        return (((op1 ^ op2) ^ res) ^ ((op1 ^ res) & (~(op1 ^ op2)))).msb()
                Severity: Major
                Found in miasm/expression/simplifications_explicit.py - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                          return (((op1 ^ op2) ^ res) ^ ((op1 ^ res) & (~(op1 ^ op2)))).msb()
                  Severity: Major
                  Found in miasm/expression/simplifications_explicit.py - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                            return (op1 - (op2 + op3.zeroExtend(op1.size))).msb()
                    Severity: Major
                    Found in miasm/expression/simplifications_explicit.py - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                              return (((op1 ^ op2) ^ res) ^ ((op1 ^ res) & (op1 ^ op2))).msb()
                      Severity: Major
                      Found in miasm/expression/simplifications_explicit.py - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                                return op_cf | op_zf
                        Severity: Major
                        Found in miasm/expression/simplifications_explicit.py - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                                  return op_zf | (op_nf ^ op_of)
                          Severity: Major
                          Found in miasm/expression/simplifications_explicit.py - About 30 mins to fix

                            Avoid too many return statements within this function.
                            Open

                                    return ~op_zf
                            Severity: Major
                            Found in miasm/expression/simplifications_explicit.py - About 30 mins to fix

                              Avoid too many return statements within this function.
                              Open

                                      return op_cf
                              Severity: Major
                              Found in miasm/expression/simplifications_explicit.py - About 30 mins to fix

                                Avoid too many return statements within this function.
                                Open

                                        return op_zf
                                Severity: Major
                                Found in miasm/expression/simplifications_explicit.py - About 30 mins to fix

                                  Avoid too many return statements within this function.
                                  Open

                                          return ~(op_cf | op_zf)
                                  Severity: Major
                                  Found in miasm/expression/simplifications_explicit.py - About 30 mins to fix

                                    Avoid too many return statements within this function.
                                    Open

                                            return ~(op_nf ^ op_of)
                                    Severity: Major
                                    Found in miasm/expression/simplifications_explicit.py - About 30 mins to fix

                                      Avoid too many return statements within this function.
                                      Open

                                          return expr
                                      Severity: Major
                                      Found in miasm/expression/simplifications_explicit.py - About 30 mins to fix

                                        Avoid too many return statements within this function.
                                        Open

                                                return op_nf ^ op_of
                                        Severity: Major
                                        Found in miasm/expression/simplifications_explicit.py - About 30 mins to fix

                                          Avoid too many return statements within this function.
                                          Open

                                                  return ExprCond(res, ExprInt(0, 1), ExprInt(1, 1))
                                          Severity: Major
                                          Found in miasm/expression/simplifications_explicit.py - About 30 mins to fix

                                            Avoid too many return statements within this function.
                                            Open

                                                    return ~(op_zf | (op_nf ^ op_of))
                                            Severity: Major
                                            Found in miasm/expression/simplifications_explicit.py - About 30 mins to fix

                                              Avoid too many return statements within this function.
                                              Open

                                                      return op_nf
                                              Severity: Major
                                              Found in miasm/expression/simplifications_explicit.py - About 30 mins to fix

                                                Avoid too many return statements within this function.
                                                Open

                                                        return ~op_nf
                                                Severity: Major
                                                Found in miasm/expression/simplifications_explicit.py - About 30 mins to fix

                                                  Avoid too many return statements within this function.
                                                  Open

                                                          return ~op_cf
                                                  Severity: Major
                                                  Found in miasm/expression/simplifications_explicit.py - About 30 mins to fix

                                                    Identical blocks of code found in 2 locations. Consider refactoring.
                                                    Open

                                                            return (((op1 ^ op2) ^ res) ^ ((op1 ^ res) & (~(op1 ^ op2)))).msb()
                                                    Severity: Major
                                                    Found in miasm/expression/simplifications_explicit.py and 1 other location - About 1 hr to fix
                                                    miasm/expression/simplifications_explicit.py on lines 89..89

                                                    Duplicated Code

                                                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                                    Tuning

                                                    This issue has a mass of 47.

                                                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                                    Refactorings

                                                    Further Reading

                                                    Identical blocks of code found in 2 locations. Consider refactoring.
                                                    Open

                                                            return (((op1 ^ op2) ^ res) ^ ((op1 ^ res) & (~(op1 ^ op2)))).msb()
                                                    Severity: Major
                                                    Found in miasm/expression/simplifications_explicit.py and 1 other location - About 1 hr to fix
                                                    miasm/expression/simplifications_explicit.py on lines 51..51

                                                    Duplicated Code

                                                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                                    Tuning

                                                    This issue has a mass of 47.

                                                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                                    Refactorings

                                                    Further Reading

                                                    Identical blocks of code found in 2 locations. Consider refactoring.
                                                    Open

                                                            return (((op1 ^ op2) ^ res) ^ ((op1 ^ res) & (op1 ^ op2))).msb()
                                                    Severity: Major
                                                    Found in miasm/expression/simplifications_explicit.py and 1 other location - About 1 hr to fix
                                                    miasm/expression/simplifications_explicit.py on lines 94..94

                                                    Duplicated Code

                                                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                                    Tuning

                                                    This issue has a mass of 43.

                                                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                                    Refactorings

                                                    Further Reading

                                                    Identical blocks of code found in 2 locations. Consider refactoring.
                                                    Open

                                                            return (((op1 ^ op2) ^ res) ^ ((op1 ^ res) & (op1 ^ op2))).msb()
                                                    Severity: Major
                                                    Found in miasm/expression/simplifications_explicit.py and 1 other location - About 1 hr to fix
                                                    miasm/expression/simplifications_explicit.py on lines 56..56

                                                    Duplicated Code

                                                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                                    Tuning

                                                    This issue has a mass of 43.

                                                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                                    Refactorings

                                                    Further Reading

                                                    Identical blocks of code found in 3 locations. Consider refactoring.
                                                    Open

                                                            new_expr = ExprCompose(
            arg,
            ExprCond(
                arg.msb(),
                ExprInt(size2mask(add_size), add_size),
                                                    Severity: Major
                                                    Found in miasm/expression/simplifications_explicit.py and 2 other locations - About 40 mins to fix
                                                    miasm/ir/translators/C.py on lines 167..172
                                                    miasm/jitter/llvmconvert.py on lines 903..908

                                                    Duplicated Code

                                                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                                    Tuning

                                                    This issue has a mass of 34.

                                                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                                    Refactorings

                                                    Further Reading

                                                    There are no issues that match your filters.

                                                    Category
                                                    Status