cea-sec/miasm

View on GitHub
miasm/os_dep/linux_stdlib.py

Summary

Maintainability
A
2 hrs
Test Coverage

Similar blocks of code found in 3 locations. Consider refactoring.
Open

def xxx_malloc(jitter):
    ret_ad, args = jitter.func_args_systemv(["msize"])
    addr = linobjs.heap.alloc(jitter, args.msize)
    jitter.func_ret_systemv(ret_ad, addr)
Severity: Major
Found in miasm/os_dep/linux_stdlib.py and 2 other locations - About 1 hr to fix
miasm/os_dep/win_api_x86_32.py on lines 303..306
miasm/os_dep/win_api_x86_32.py on lines 2930..2933

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 16 locations. Consider refactoring.
Open

def xxx_free(jitter):
    ret_ad, args = jitter.func_args_systemv(["ptr"])
    jitter.func_ret_systemv(ret_ad, 0)
Severity: Major
Found in miasm/os_dep/linux_stdlib.py and 15 other locations - About 30 mins to fix
miasm/os_dep/win_api_x86_32.py on lines 293..295
miasm/os_dep/win_api_x86_32.py on lines 310..312
miasm/os_dep/win_api_x86_32.py on lines 316..318
miasm/os_dep/win_api_x86_32.py on lines 412..414
miasm/os_dep/win_api_x86_32.py on lines 422..424
miasm/os_dep/win_api_x86_32.py on lines 473..475
miasm/os_dep/win_api_x86_32.py on lines 478..480
miasm/os_dep/win_api_x86_32.py on lines 590..592
miasm/os_dep/win_api_x86_32.py on lines 1348..1350
miasm/os_dep/win_api_x86_32.py on lines 1994..1998
miasm/os_dep/win_api_x86_32.py on lines 2429..2431
miasm/os_dep/win_api_x86_32.py on lines 2556..2558
miasm/os_dep/win_api_x86_32.py on lines 2806..2808
miasm/os_dep/win_api_x86_32.py on lines 2936..2938
miasm/os_dep/win_api_x86_32.py on lines 3006..3008

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 32.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status