Sign upLogin

cellog/ion-router

View on GitHub
Star
src/enhancers.ts

Summary

Maintainability
B
4 hrs
Test Coverage

Function enhanceRoute has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function enhanceRoute<
  ReduxState extends FullStateWithRouter,
  Params extends { [key: string]: string },
  ParamsState extends { [key: string]: any },
  Action extends { type: string; [key: string]: any }
Severity: Minor
Found in src/enhancers.ts - About 1 hr to fix

    Identical blocks of code found in 10 locations. Consider refactoring.
    Open

    export interface DeclareRoute<
  ReduxState extends FullStateWithRouter,
  Params extends { [key: string]: string },
  ParamsState extends { [key: string]: any },
  Action extends { type: string; [key: string]: any }
    Severity: Major
    Found in src/enhancers.ts and 9 other locations - About 1 hr to fix
    src/Context.ts on lines 11..18
    src/Route.tsx on lines 10..39
    src/Route.tsx on lines 47..82
    src/Routes.tsx on lines 13..82
    src/actions.ts on lines 68..88
    src/actions.ts on lines 160..171
    src/actions.ts on lines 173..185
    src/enhancers.ts on lines 28..39
    src/enhancers.ts on lines 50..85

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 60.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 10 locations. Consider refactoring.
    Open

    export function enhanceRoute<
  ReduxState extends FullStateWithRouter,
  Params extends { [key: string]: string },
  ParamsState extends { [key: string]: any },
  Action extends { type: string; [key: string]: any }
    Severity: Major
    Found in src/enhancers.ts and 9 other locations - About 1 hr to fix
    src/Context.ts on lines 11..18
    src/Route.tsx on lines 10..39
    src/Route.tsx on lines 47..82
    src/Routes.tsx on lines 13..82
    src/actions.ts on lines 68..88
    src/actions.ts on lines 160..171
    src/actions.ts on lines 173..185
    src/enhancers.ts on lines 5..18
    src/enhancers.ts on lines 28..39

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 60.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 10 locations. Consider refactoring.
    Open

    export interface EnhancedRoute<
  ReduxState extends FullStateWithRouter,
  Params extends { [key: string]: string },
  ParamsState extends { [key: string]: any },
  Action extends { type: string; [key: string]: any }
    Severity: Major
    Found in src/enhancers.ts and 9 other locations - About 1 hr to fix
    src/Context.ts on lines 11..18
    src/Route.tsx on lines 10..39
    src/Route.tsx on lines 47..82
    src/Routes.tsx on lines 13..82
    src/actions.ts on lines 68..88
    src/actions.ts on lines 160..171
    src/actions.ts on lines 173..185
    src/enhancers.ts on lines 5..18
    src/enhancers.ts on lines 50..85

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 60.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status