Sign upLogin

celluloid/celluloid

View on GitHub
Star
lib/celluloid/supervision/container/pool.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Class Pool has 23 methods (exceeds 20 allowed). Consider refactoring.
Open

      class Pool
        include Celluloid

        trap_exit :__crash_handler__
        finalizer :__shutdown__
Severity: Minor
Found in lib/celluloid/supervision/container/pool.rb - About 2 hrs to fix

    Method respond_to? has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

            def respond_to?(meth, include_private = false)
          # NOTE: use method() here since this class
          # shouldn't be used directly, and method() is less
          # likely to be "reimplemented" inconsistently
          # with other Object.*method* methods.
    Severity: Minor
    Found in lib/celluloid/supervision/container/pool.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method __shutdown__ has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

            def __shutdown__
          return unless defined?(@actors) && @actors
          # TODO: these can be nil if initializer crashes
          terminators = @actors.map do |actor|
            begin
    Severity: Minor
    Found in lib/celluloid/supervision/container/pool.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status