Sign upLogin

cerebris/jsonapi-resources

View on GitHub
Star
lib/jsonapi/resource_set.rb

Summary

Maintainability
C
1 day
Test Coverage

Method populate! has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
Open

    def populate!(serializer, context, options)
      return if @populated

      # For each resource klass we want to generate the caching key
Severity: Minor
Found in lib/jsonapi/resource_set.rb - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method populate! has 82 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def populate!(serializer, context, options)
      return if @populated

      # For each resource klass we want to generate the caching key
Severity: Major
Found in lib/jsonapi/resource_set.rb - About 3 hrs to fix

    Method flatten_resource_tree has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        def flatten_resource_tree(resource_tree, flattened_tree = {})
      resource_tree.fragments.each_pair do |resource_rid, fragment|

        resource_klass = resource_rid.resource_klass
        id = resource_rid.id
    Severity: Minor
    Found in lib/jsonapi/resource_set.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status