cforlando/orlando-walking-tours-ios

View on GitHub

Showing 47 of 47 total issues

Function getLocations has a Cognitive Complexity of 68 (exceeds 5 allowed). Consider refactoring.
Open

    func getLocations(completion: @escaping (_ locations: [HistoricLocation]) -> Void)
    {
        var locations = [HistoricLocation]()

        Alamofire.request(locationsUrlString).validate().responseJSON
Severity: Minor
Found in Orlando Walking Tours/Services/SocrataDataService.swift - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getLocations has a Cognitive Complexity of 38 (exceeds 5 allowed). Consider refactoring.
Open

    func getLocations(completion: @escaping ([HistoricLocation]) -> Void)
    {
        let historicLocationsRef = databaseRef.child("historic-locations").child("orlando")

        historicLocationsRef.observeSingleEvent(of: .value, with:
Severity: Minor
Found in Orlando Walking Tours/Services/FirebaseDataService.swift - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File LocationListVC.swift has 273 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import UIKit
import MapKit
import MagicalRecord

class LocationListVC: UIViewController
Severity: Minor
Found in Orlando Walking Tours/Controllers/LocationListVC.swift - About 2 hrs to fix

    Function getLocations has 59 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        func getLocations(completion: @escaping (_ locations: [HistoricLocation]) -> Void)
        {
            var locations = [HistoricLocation]()
    
            Alamofire.request(locationsUrlString).validate().responseJSON
    Severity: Major
    Found in Orlando Walking Tours/Services/SocrataDataService.swift - About 2 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          override func prepare(for segue: UIStoryboardSegue, sender: Any?)
          {
              super.prepare(for: segue, sender: sender)
      
              if let navController = segue.destination as? UINavigationController
      Severity: Major
      Found in Orlando Walking Tours/Controllers/CurrentTourVC.swift and 1 other location - About 2 hrs to fix
      Orlando Walking Tours/Controllers/LocationListVC.swift on lines 123..144

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 143.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          override func prepare(for segue: UIStoryboardSegue, sender: Any?)
          {
              super.prepare(for: segue, sender: sender)
      
              if let navController = segue.destination as? UINavigationController
      Severity: Major
      Found in Orlando Walking Tours/Controllers/LocationListVC.swift and 1 other location - About 2 hrs to fix
      Orlando Walking Tours/Controllers/CurrentTourVC.swift on lines 85..105

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 143.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function getLocations has 47 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          func getLocations(completion: @escaping ([HistoricLocation]) -> Void)
          {
              let historicLocationsRef = databaseRef.child("historic-locations").child("orlando")
      
              historicLocationsRef.observeSingleEvent(of: .value, with:
      Severity: Minor
      Found in Orlando Walking Tours/Services/FirebaseDataService.swift - About 1 hr to fix

        Function setAvailableTourLocations has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

            func setAvailableTourLocations(allLocations: [HistoricLocation])
            {
                if let tourLocations = self.tour?.historicLocations
                {
                    if tourLocations.count > 0
        Severity: Minor
        Found in Orlando Walking Tours/Controllers/LocationListVC.swift - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function layoutAttributesForElements has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

            override func layoutAttributesForElements(in rect: CGRect) -> [UICollectionViewLayoutAttributes]?
            {
                if let attributesArrayInRect = super.layoutAttributesForElements(in: rect)
                {
                    for attributes in attributesArrayInRect
        Severity: Minor
        Found in Orlando Walking Tours/Views/DashboardViewFlowLayout.swift - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function deleteTour has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

            func deleteTour(_ sender: UIButton)
            {
                if let cell = sender.superview?.superview as? DashboardCollectionViewCell
                {
                    let alertController = UIAlertController(title: "Are you sure?", message: "Are you sure you want to delete \(cell.tourName.text!)?", preferredStyle: .alert)
        Severity: Minor
        Found in Orlando Walking Tours/Controllers/DashboardVC.swift - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function viewWillAppear has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            override func viewWillAppear(_ animated: Bool)
            {
                super.viewWillAppear(animated)
        
                guard let location = location else
        Severity: Minor
        Found in Orlando Walking Tours/Controllers/LocationDetailVC.swift - About 1 hr to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              func loadImage(width: CGFloat, height: CGFloat)
              {
                  loadingIndicator.startAnimating()
          
                  // TODO: Image view for cell should be random photo of a location from the tour
          Severity: Minor
          Found in Orlando Walking Tours/Views/LocationTableViewCell.swift and 1 other location - About 55 mins to fix
          Orlando Walking Tours/Views/DashboardCollectionViewCell.swift on lines 86..95

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 67.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              func loadImage(width: CGFloat, height: CGFloat)
              {
                  loadingIndicator.startAnimating()
                  
                  // TODO: Image view for cell should be random photo of a location from the tour
          Severity: Minor
          Found in Orlando Walking Tours/Views/DashboardCollectionViewCell.swift and 1 other location - About 55 mins to fix
          Orlando Walking Tours/Views/LocationTableViewCell.swift on lines 51..60

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 67.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  if self.isDeletionModeActive
                  {
                      if (self.collectionView.indexPathForItem(at: tapRecognizer.location(in: self.collectionView)) == nil)
                      {
                          self.isDeletionModeActive = false
          Severity: Minor
          Found in Orlando Walking Tours/Controllers/DashboardVC.swift and 1 other location - About 50 mins to fix
          Orlando Walking Tours/Controllers/DashboardVC.swift on lines 102..110

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 58.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  if gestureRecognizer.state == .began
                  {
                      if (self.collectionView.indexPathForItem(at: gestureRecognizer.location(in: self.collectionView)) != nil)
                      {
                          self.isDeletionModeActive = true
          Severity: Minor
          Found in Orlando Walking Tours/Controllers/DashboardVC.swift and 1 other location - About 50 mins to fix
          Orlando Walking Tours/Controllers/DashboardVC.swift on lines 117..125

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 58.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Avoid deeply nested control flow statements.
          Open

                                      if let id = subJson["id"].string
                                      {
                                          location.id = NumberFormatter().number(from: id)
                                      }
          Severity: Major
          Found in Orlando Walking Tours/Services/SocrataDataService.swift - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                                        if let localRegistryDate = locationJSON["localRegistryDate"].string
                                        {
                                            location.localRegistryDate = formatter.date(from: localRegistryDate) as NSDate?
                                        }
            Severity: Major
            Found in Orlando Walking Tours/Services/FirebaseDataService.swift - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                                          if let description = subJson["downtown_walking_tour"].string
                                          {
                                              location.locationDescription = description
                                          }
              Severity: Major
              Found in Orlando Walking Tours/Services/SocrataDataService.swift - About 45 mins to fix

                Avoid deeply nested control flow statements.
                Open

                                            if let locationType = subJson["type"].string
                                            {
                                                location.locationType = locationType
                                            }
                Severity: Major
                Found in Orlando Walking Tours/Services/SocrataDataService.swift - About 45 mins to fix

                  Avoid deeply nested control flow statements.
                  Open

                                              if let longitude = subJson["location"]["coordinates"][0].double
                                              {
                                                  location.longitude = NSNumber(value: longitude)
                                              }
                  Severity: Major
                  Found in Orlando Walking Tours/Services/SocrataDataService.swift - About 45 mins to fix
                    Severity
                    Category
                    Status
                    Source
                    Language