cfpb/owning-a-home

View on GitHub
src/_lib/wordpress_journey_processor.py

Summary

Maintainability
C
1 day
Test Coverage

Function process_journey has a Cognitive Complexity of 56 (exceeds 5 allowed). Consider refactoring.
Open

def process_journey(item):

    del item['comments']
    del item['date']
    custom_fields = item['custom_fields']
Severity: Minor
Found in src/_lib/wordpress_journey_processor.py - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

                    if field_name in custom_fields:
                        if field == 'link':
                            tool[field] = \
                                {'url': custom_fields[field_name][0],
                                 'label': custom_fields[field_name][1]}
Severity: Major
Found in src/_lib/wordpress_journey_processor.py - About 45 mins to fix

    There are no issues that match your filters.

    Category
    Status