Sign upLogin

cgimenes/binqr-server

View on GitHub
Star

Showing 5 of 5 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    } else {
        buttonText.innerText = "Modo manual";
        gif.classList.remove("is-hidden");
        qrcodes.classList.add("is-hidden");
        buttonIcon.classList.remove("fa-thumbs-up");
Severity: Major
Found in static/js/success.js and 1 other location - About 1 hr to fix
static/js/success.js on lines 10..16

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 74.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    if (fallbackEnabled) {
        buttonText.innerText = "Modo normal";
        gif.classList.add("is-hidden");
        qrcodes.classList.remove("is-hidden");
        buttonIcon.classList.remove("fa-thumbs-down");
Severity: Major
Found in static/js/success.js and 1 other location - About 1 hr to fix
static/js/success.js on lines 16..22

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 74.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function onload has 44 lines of code (exceeds 25 allowed). Consider refactoring.
Open

window.onload = function(){
    var form = document.getElementById("file-form");
    var fileSelect = document.getElementById("file-select");
    var uploadButton = document.getElementById("upload-button");
    var fileName = document.getElementById("file-name");
Severity: Minor
Found in static/js/index.js - About 1 hr to fix

    Function onload has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

    window.onload = function(){
    var form = document.getElementById("file-form");
    var fileSelect = document.getElementById("file-select");
    var uploadButton = document.getElementById("upload-button");
    var fileName = document.getElementById("file-name");
    Severity: Minor
    Found in static/js/index.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function onsubmit has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        form.onsubmit = function(event) {
        event.preventDefault();

        // Get the selected files from the input.
        var files = fileSelect.files;
    Severity: Minor
    Found in static/js/index.js - About 1 hr to fix
      Severity
      Category
      Status
      Source
      Language