chamilo/chamilo-lms

View on GitHub
public/main/admin/course_list_admin.php

Summary

Maintainability
A
0 mins
Test Coverage

The function get_course_data() has an NPath complexity of 793152. The configured NPath complexity threshold is 200.
Open

function get_course_data($from, $number_of_items, $column, $direction, $dataFunctions = [], $getCount = false)
{
    $addTeacherColumn = true;
    $table = Database::get_main_table(TABLE_MAIN_COURSE);

NPathComplexity

Since: 0.1

The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

Example

class Foo {
    function bar() {
        // lots of complicated code
    }
}

Source https://phpmd.org/rules/codesize.html#npathcomplexity

Avoid unused parameters such as '$dataFunctions'.
Open

function get_course_data($from, $number_of_items, $column, $direction, $dataFunctions = [], $getCount = false)

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

The parameter $number_of_items is not named in camelCase.
Open

function get_course_data($from, $number_of_items, $column, $direction, $dataFunctions = [], $getCount = false)
{
    $addTeacherColumn = true;
    $table = Database::get_main_table(TABLE_MAIN_COURSE);

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

Variable "keyword_category" is not in valid camel caps format
Open

        if (!empty($keyword_category)) {

Consider putting global function "get_course_visibility_icon" in a static class
Open

function get_course_visibility_icon($visibility)

Variable "number_of_items" is not in valid camel caps format
Open

function get_course_data($from, $number_of_items, $column, $direction, $dataFunctions = [], $getCount = false)

Variable "number_of_items" is not in valid camel caps format
Open

    $number_of_items = (int) $number_of_items;

Variable "access_url_rel_course_table" is not in valid camel caps format
Open

        $access_url_rel_course_table = Database::get_main_table(TABLE_MAIN_ACCESS_URL_REL_COURSE);

Variable "keyword_subscribe" is not in valid camel caps format
Open

                subscribe LIKE '".$keyword_subscribe."' AND

Variable "keyword_visibility" is not in valid camel caps format
Open

        $keyword_visibility = Database::escape_string("%".$_GET['keyword_visibility']."%");

Variable "keyword_language" is not in valid camel caps format
Open

                course_language LIKE '".$keyword_language."' AND

Variable "keyword_category" is not in valid camel caps format
Open

            $sql .= " AND category_code LIKE '".$keyword_category."' ";

Variable "this_section" is not in valid camel caps format
Open

$this_section = SECTION_PLATFORM_ADMIN;

Variable "number_of_items" is not in valid camel caps format
Open

    $number_of_items = (int) $number_of_items;

Variable "keyword_language" is not in valid camel caps format
Open

        $keyword_language = Database::escape_string("%".$_GET['keyword_language']."%");

Variable "course_code" is not in valid camel caps format
Open

                        CourseManager::delete_course($course_code);

Variable "tool_name" is not in valid camel caps format
Open

$tpl = new Template($tool_name);

Variable "keyword_subscribe" is not in valid camel caps format
Open

        $keyword_subscribe = Database::escape_string($_GET['keyword_subscribe']);

Consider putting global function "get_course_data" in a static class
Open

function get_course_data($from, $number_of_items, $column, $direction, $dataFunctions = [], $getCount = false)

Variable "keyword_title" is not in valid camel caps format
Open

        $keyword_title = Database::escape_string("%".$_GET['keyword_title']."%");

Variable "keyword_title" is not in valid camel caps format
Open

                title LIKE '".$keyword_title."' AND

Variable "keyword_code" is not in valid camel caps format
Open

                (code LIKE '".$keyword_code."' OR visual_code LIKE '".$keyword_code."') AND

Variable "course_codes" is not in valid camel caps format
Open

                    foreach ($course_codes as $course_code) {

Variable "course_code" is not in valid camel caps format
Open

                    foreach ($course_codes as $course_code) {

Variable "tool_name" is not in valid camel caps format
Open

    $form->addElement('header', $tool_name);

Variable "keyword_unsubscribe" is not in valid camel caps format
Open

        $keyword_unsubscribe = Database::escape_string($_GET['keyword_unsubscribe']);

Variable "keyword_visibility" is not in valid camel caps format
Open

                visibility LIKE '".$keyword_visibility."' AND

Variable "keyword_unsubscribe" is not in valid camel caps format
Open

                unsubscribe LIKE '".$keyword_unsubscribe."'";

Variable "course_codes" is not in valid camel caps format
Open

                if (count($course_codes) > 0) {

Variable "keyword_code" is not in valid camel caps format
Open

                (code LIKE '".$keyword_code."' OR visual_code LIKE '".$keyword_code."') AND

Variable "tool_name" is not in valid camel caps format
Open

    $tool_name = get_lang('Search courses');

Variable "tool_name" is not in valid camel caps format
Open

    $tool_name = get_lang('CourseList');

Variable "number_of_items" is not in valid camel caps format
Open

    $sql .= " LIMIT $from, $number_of_items";

Consider putting global function "get_number_of_courses" in a static class
Open

function get_number_of_courses()

Variable "access_url_rel_course_table" is not in valid camel caps format
Open

        $sql .= " INNER JOIN $access_url_rel_course_table url_rel_course

Variable "keyword_category" is not in valid camel caps format
Open

        $keyword_category = isset($_GET['keyword_category'])

Variable "course_codes" is not in valid camel caps format
Open

                $course_codes = $_POST['course'];

Variable "keyword_code" is not in valid camel caps format
Open

        $keyword_code = Database::escape_string("%".$_GET['keyword_code']."%");

The variable $keyword_subscribe is not named in camelCase.
Open

function get_course_data($from, $number_of_items, $column, $direction, $dataFunctions = [], $getCount = false)
{
    $addTeacherColumn = true;
    $table = Database::get_main_table(TABLE_MAIN_COURSE);

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $keyword_category is not named in camelCase.
Open

function get_course_data($from, $number_of_items, $column, $direction, $dataFunctions = [], $getCount = false)
{
    $addTeacherColumn = true;
    $table = Database::get_main_table(TABLE_MAIN_COURSE);

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $keyword_visibility is not named in camelCase.
Open

function get_course_data($from, $number_of_items, $column, $direction, $dataFunctions = [], $getCount = false)
{
    $addTeacherColumn = true;
    $table = Database::get_main_table(TABLE_MAIN_COURSE);

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $keyword_title is not named in camelCase.
Open

function get_course_data($from, $number_of_items, $column, $direction, $dataFunctions = [], $getCount = false)
{
    $addTeacherColumn = true;
    $table = Database::get_main_table(TABLE_MAIN_COURSE);

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $keyword_category is not named in camelCase.
Open

function get_course_data($from, $number_of_items, $column, $direction, $dataFunctions = [], $getCount = false)
{
    $addTeacherColumn = true;
    $table = Database::get_main_table(TABLE_MAIN_COURSE);

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $keyword_code is not named in camelCase.
Open

function get_course_data($from, $number_of_items, $column, $direction, $dataFunctions = [], $getCount = false)
{
    $addTeacherColumn = true;
    $table = Database::get_main_table(TABLE_MAIN_COURSE);

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $keyword_title is not named in camelCase.
Open

function get_course_data($from, $number_of_items, $column, $direction, $dataFunctions = [], $getCount = false)
{
    $addTeacherColumn = true;
    $table = Database::get_main_table(TABLE_MAIN_COURSE);

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $keyword_language is not named in camelCase.
Open

function get_course_data($from, $number_of_items, $column, $direction, $dataFunctions = [], $getCount = false)
{
    $addTeacherColumn = true;
    $table = Database::get_main_table(TABLE_MAIN_COURSE);

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $keyword_code is not named in camelCase.
Open

function get_course_data($from, $number_of_items, $column, $direction, $dataFunctions = [], $getCount = false)
{
    $addTeacherColumn = true;
    $table = Database::get_main_table(TABLE_MAIN_COURSE);

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $access_url_rel_course_table is not named in camelCase.
Open

function get_course_data($from, $number_of_items, $column, $direction, $dataFunctions = [], $getCount = false)
{
    $addTeacherColumn = true;
    $table = Database::get_main_table(TABLE_MAIN_COURSE);

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $keyword_subscribe is not named in camelCase.
Open

function get_course_data($from, $number_of_items, $column, $direction, $dataFunctions = [], $getCount = false)
{
    $addTeacherColumn = true;
    $table = Database::get_main_table(TABLE_MAIN_COURSE);

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $keyword_category is not named in camelCase.
Open

function get_course_data($from, $number_of_items, $column, $direction, $dataFunctions = [], $getCount = false)
{
    $addTeacherColumn = true;
    $table = Database::get_main_table(TABLE_MAIN_COURSE);

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $number_of_items is not named in camelCase.
Open

function get_course_data($from, $number_of_items, $column, $direction, $dataFunctions = [], $getCount = false)
{
    $addTeacherColumn = true;
    $table = Database::get_main_table(TABLE_MAIN_COURSE);

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $number_of_items is not named in camelCase.
Open

function get_course_data($from, $number_of_items, $column, $direction, $dataFunctions = [], $getCount = false)
{
    $addTeacherColumn = true;
    $table = Database::get_main_table(TABLE_MAIN_COURSE);

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $keyword_code is not named in camelCase.
Open

function get_course_data($from, $number_of_items, $column, $direction, $dataFunctions = [], $getCount = false)
{
    $addTeacherColumn = true;
    $table = Database::get_main_table(TABLE_MAIN_COURSE);

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $keyword_unsubscribe is not named in camelCase.
Open

function get_course_data($from, $number_of_items, $column, $direction, $dataFunctions = [], $getCount = false)
{
    $addTeacherColumn = true;
    $table = Database::get_main_table(TABLE_MAIN_COURSE);

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $keyword_visibility is not named in camelCase.
Open

function get_course_data($from, $number_of_items, $column, $direction, $dataFunctions = [], $getCount = false)
{
    $addTeacherColumn = true;
    $table = Database::get_main_table(TABLE_MAIN_COURSE);

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $keyword_language is not named in camelCase.
Open

function get_course_data($from, $number_of_items, $column, $direction, $dataFunctions = [], $getCount = false)
{
    $addTeacherColumn = true;
    $table = Database::get_main_table(TABLE_MAIN_COURSE);

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $access_url_rel_course_table is not named in camelCase.
Open

function get_course_data($from, $number_of_items, $column, $direction, $dataFunctions = [], $getCount = false)
{
    $addTeacherColumn = true;
    $table = Database::get_main_table(TABLE_MAIN_COURSE);

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $number_of_items is not named in camelCase.
Open

function get_course_data($from, $number_of_items, $column, $direction, $dataFunctions = [], $getCount = false)
{
    $addTeacherColumn = true;
    $table = Database::get_main_table(TABLE_MAIN_COURSE);

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $keyword_unsubscribe is not named in camelCase.
Open

function get_course_data($from, $number_of_items, $column, $direction, $dataFunctions = [], $getCount = false)
{
    $addTeacherColumn = true;
    $table = Database::get_main_table(TABLE_MAIN_COURSE);

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

There are no issues that match your filters.

Category
Status