Sign upLogin

chamilo/chamilo-lms

View on GitHub
Star
public/main/admin/course_request_edit.php

Summary

Maintainability
A
0 mins
Test Coverage

The parameter $caller_id is not named in camelCase.
Open

function get_caller_name($caller_id)
{
    switch ($caller_id) {
        case 1:
            return 'course_request_accepted.php';
Severity: Minor
Found in public/main/admin/course_request_edit.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

Variable "course_request_info" is not in valid camel caps format
Open

            $data = CourseCategory::getCategory($course_request_info['category_code']);
Severity: Minor
Found in public/main/admin/course_request_edit.php by phpcodesniffer

Variable "course_request_info" is not in valid camel caps format
Open

        if (COURSE_REQUEST_ACCEPTED != $course_request_info['status'] && (int) ($course_request_info['info']) <= 0) {
Severity: Minor
Found in public/main/admin/course_request_edit.php by phpcodesniffer

Variable "course_request_info" is not in valid camel caps format
Open

        $values['course_language'] = $course_request_info['course_language'];
Severity: Minor
Found in public/main/admin/course_request_edit.php by phpcodesniffer

Variable "course_request_values" is not in valid camel caps format
Open

                                            $course_request_values['wanted_code']
Severity: Minor
Found in public/main/admin/course_request_edit.php by phpcodesniffer

Variable "course_request_info" is not in valid camel caps format
Open

if (!is_array($course_request_info)) {
Severity: Minor
Found in public/main/admin/course_request_edit.php by phpcodesniffer

Variable "course_validation_feature" is not in valid camel caps format
Open

if ($course_validation_feature) {
Severity: Minor
Found in public/main/admin/course_request_edit.php by phpcodesniffer

Variable "course_request_values" is not in valid camel caps format
Open

            $course_request_values = $form->getSubmitValues();
Severity: Minor
Found in public/main/admin/course_request_edit.php by phpcodesniffer

Variable "course_request_values" is not in valid camel caps format
Open

                    $course_request_values['objetives'],
Severity: Minor
Found in public/main/admin/course_request_edit.php by phpcodesniffer

Variable "course_request_values" is not in valid camel caps format
Open

                    $course_request_values['exemplary_content']
Severity: Minor
Found in public/main/admin/course_request_edit.php by phpcodesniffer

Variable "course_request_info" is not in valid camel caps format
Open

        $values['description'] = $course_request_info['description'];
Severity: Minor
Found in public/main/admin/course_request_edit.php by phpcodesniffer

Variable "course_request_values" is not in valid camel caps format
Open

                                $course_request_values['wanted_code']
Severity: Minor
Found in public/main/admin/course_request_edit.php by phpcodesniffer

Variable "submit_button" is not in valid camel caps format
Open

                    switch ($submit_button) {
Severity: Minor
Found in public/main/admin/course_request_edit.php by phpcodesniffer

Variable "course_request_values" is not in valid camel caps format
Open

                                            $course_request_values['wanted_code']
Severity: Minor
Found in public/main/admin/course_request_edit.php by phpcodesniffer

Variable "course_request_values" is not in valid camel caps format
Open

                        $course_request_values['wanted_code'].' - '.get_lang('CourseCourse codeAlreadyExists')
Severity: Minor
Found in public/main/admin/course_request_edit.php by phpcodesniffer

Variable "course_request_values" is not in valid camel caps format
Open

                    $course_request_values['target_audience'],
Severity: Minor
Found in public/main/admin/course_request_edit.php by phpcodesniffer

Variable "course_request_values" is not in valid camel caps format
Open

                                            $course_request_values['wanted_code'],
Severity: Minor
Found in public/main/admin/course_request_edit.php by phpcodesniffer

Consider putting global function "get_caller_name" in a static class
Open

function get_caller_name($caller_id)
Severity: Minor
Found in public/main/admin/course_request_edit.php by phpcodesniffer

Variable "course_request_info" is not in valid camel caps format
Open

        if (COURSE_REQUEST_ACCEPTED != $course_request_info['status'] &&
Severity: Minor
Found in public/main/admin/course_request_edit.php by phpcodesniffer

Variable "course_request_info" is not in valid camel caps format
Open

        $values['visual_code'] = $course_request_info['visual_code'];
Severity: Minor
Found in public/main/admin/course_request_edit.php by phpcodesniffer

Variable "update_ok" is not in valid camel caps format
Open

                $update_ok = CourseRequestManager::update_course_request(
Severity: Minor
Found in public/main/admin/course_request_edit.php by phpcodesniffer

Variable "course_request_values" is not in valid camel caps format
Open

                    $course_request_values['title'],
Severity: Minor
Found in public/main/admin/course_request_edit.php by phpcodesniffer

Variable "course_request_info" is not in valid camel caps format
Open

        $values['info'] = $course_request_info['info'];
Severity: Minor
Found in public/main/admin/course_request_edit.php by phpcodesniffer

Variable "course_code_ok" is not in valid camel caps format
Open

            $course_code_ok = $course_request_values['wanted_code'] == $course_request_info['code']
Severity: Minor
Found in public/main/admin/course_request_edit.php by phpcodesniffer

You must use "/**" style comments for a function comment
Open

function get_caller_name($caller_id)
Severity: Minor
Found in public/main/admin/course_request_edit.php by phpcodesniffer

Variable "tool_name" is not in valid camel caps format
Open

Display :: display_header($tool_name);
Severity: Minor
Found in public/main/admin/course_request_edit.php by phpcodesniffer

Variable "course_request_info" is not in valid camel caps format
Open

    if (!is_array($course_request_info)) {
Severity: Minor
Found in public/main/admin/course_request_edit.php by phpcodesniffer

Variable "course_request_info" is not in valid camel caps format
Open

        $values['title'] = $course_request_info['title'];
Severity: Minor
Found in public/main/admin/course_request_edit.php by phpcodesniffer

Variable "back_url" is not in valid camel caps format
Open

                $back_url = get_caller_name($caller);
Severity: Minor
Found in public/main/admin/course_request_edit.php by phpcodesniffer

Variable "tool_name" is not in valid camel caps format
Open

$tool_name = get_lang('Edit a course request');
Severity: Minor
Found in public/main/admin/course_request_edit.php by phpcodesniffer

Variable "course_request_info" is not in valid camel caps format
Open

            COURSE_REQUEST_REJECTED != $course_request_info['status']
Severity: Minor
Found in public/main/admin/course_request_edit.php by phpcodesniffer

Variable "course_request_info" is not in valid camel caps format
Open

        $values['wanted_code'] = $course_request_info['code'];
Severity: Minor
Found in public/main/admin/course_request_edit.php by phpcodesniffer

Variable "course_request_values" is not in valid camel caps format
Open

                    $course_request_values['course_language'],
Severity: Minor
Found in public/main/admin/course_request_edit.php by phpcodesniffer

Variable "update_ok" is not in valid camel caps format
Open

                if ($update_ok) {
Severity: Minor
Found in public/main/admin/course_request_edit.php by phpcodesniffer

Variable "caller_id" is not in valid camel caps format
Open

    switch ($caller_id) {
Severity: Minor
Found in public/main/admin/course_request_edit.php by phpcodesniffer

Variable "course_request_info" is not in valid camel caps format
Open

    $course_request_info = CourseRequestManager::get_course_request_info($id);
Severity: Minor
Found in public/main/admin/course_request_edit.php by phpcodesniffer

Variable "course_request_info" is not in valid camel caps format
Open

        $values['status'] = $course_request_info['status'];
Severity: Minor
Found in public/main/admin/course_request_edit.php by phpcodesniffer

Variable "course_request_values" is not in valid camel caps format
Open

            $course_code_ok = $course_request_values['wanted_code'] == $course_request_info['code']
Severity: Minor
Found in public/main/admin/course_request_edit.php by phpcodesniffer

Variable "course_request_values" is not in valid camel caps format
Open

                                            $course_request_values['wanted_code']
Severity: Minor
Found in public/main/admin/course_request_edit.php by phpcodesniffer

Variable "this_section" is not in valid camel caps format
Open

$this_section = SECTION_PLATFORM_ADMIN;
Severity: Minor
Found in public/main/admin/course_request_edit.php by phpcodesniffer

Variable "submit_buttons" is not in valid camel caps format
Open

        $submit_buttons[] = $form->addButtonSave(get_lang('Save'), 'save_button', true);
Severity: Minor
Found in public/main/admin/course_request_edit.php by phpcodesniffer

Variable "course_request_info" is not in valid camel caps format
Open

        if (COURSE_REQUEST_ACCEPTED != $course_request_info['status']) {
Severity: Minor
Found in public/main/admin/course_request_edit.php by phpcodesniffer

Variable "submit_buttons" is not in valid camel caps format
Open

            $submit_buttons[] = $form->addButtonSave(get_lang('Accept'), 'accept_button', true);
Severity: Minor
Found in public/main/admin/course_request_edit.php by phpcodesniffer

Variable "submit_buttons" is not in valid camel caps format
Open

        $form->addGroup($submit_buttons);
Severity: Minor
Found in public/main/admin/course_request_edit.php by phpcodesniffer

Variable "course_request_values" is not in valid camel caps format
Open

                : !CourseRequestManager::course_code_exists($course_request_values['wanted_code']);
Severity: Minor
Found in public/main/admin/course_request_edit.php by phpcodesniffer

Variable "course_code_ok" is not in valid camel caps format
Open

            if ($course_code_ok) {
Severity: Minor
Found in public/main/admin/course_request_edit.php by phpcodesniffer

Variable "course_request_values" is not in valid camel caps format
Open

                    $course_request_values['user_id'],
Severity: Minor
Found in public/main/admin/course_request_edit.php by phpcodesniffer

Variable "course_request_values" is not in valid camel caps format
Open

                                $course_request_values['wanted_code']
Severity: Minor
Found in public/main/admin/course_request_edit.php by phpcodesniffer

Variable "back_url" is not in valid camel caps format
Open

                header('location:'.$back_url);
Severity: Minor
Found in public/main/admin/course_request_edit.php by phpcodesniffer

Variable "course_validation_feature" is not in valid camel caps format
Open

$course_validation_feature = 'true' === api_get_setting('course_validation');
Severity: Minor
Found in public/main/admin/course_request_edit.php by phpcodesniffer

Variable "course_request_info" is not in valid camel caps format
Open

        if (!empty($course_request_info['category_code'])) {
Severity: Minor
Found in public/main/admin/course_request_edit.php by phpcodesniffer

Variable "course_request_info" is not in valid camel caps format
Open

        $values['user_id'] = $course_request_info['user_id'];
Severity: Minor
Found in public/main/admin/course_request_edit.php by phpcodesniffer

Variable "course_request_info" is not in valid camel caps format
Open

        $values['request_date'] = $course_request_info['request_date'];
Severity: Minor
Found in public/main/admin/course_request_edit.php by phpcodesniffer

Variable "submit_button" is not in valid camel caps format
Open

            $submit_button = isset($_POST['save_button']) ? 'save_button'
Severity: Minor
Found in public/main/admin/course_request_edit.php by phpcodesniffer

Variable "link_to_setting" is not in valid camel caps format
Open

            $link_to_setting,
Severity: Minor
Found in public/main/admin/course_request_edit.php by phpcodesniffer

Variable "caller_id" is not in valid camel caps format
Open

function get_caller_name($caller_id)
Severity: Minor
Found in public/main/admin/course_request_edit.php by phpcodesniffer

Variable "course_request_info" is not in valid camel caps format
Open

        if (COURSE_REQUEST_ACCEPTED != $course_request_info['status'] && (int) ($course_request_info['info']) <= 0) {
Severity: Minor
Found in public/main/admin/course_request_edit.php by phpcodesniffer

Variable "course_request_info" is not in valid camel caps format
Open

        $values['objetives'] = $course_request_info['objetives'];
Severity: Minor
Found in public/main/admin/course_request_edit.php by phpcodesniffer

Variable "course_request_info" is not in valid camel caps format
Open

        $values['target_audience'] = $course_request_info['target_audience'];
Severity: Minor
Found in public/main/admin/course_request_edit.php by phpcodesniffer

Variable "course_request_values" is not in valid camel caps format
Open

                    $course_request_values['wanted_code'],
Severity: Minor
Found in public/main/admin/course_request_edit.php by phpcodesniffer

Variable "course_request_values" is not in valid camel caps format
Open

                                            $course_request_values['wanted_code']
Severity: Minor
Found in public/main/admin/course_request_edit.php by phpcodesniffer

Variable "link_to_setting" is not in valid camel caps format
Open

    $link_to_setting = api_get_path(WEB_CODE_PATH).'admin/settings.php?search_field=course_validation&submit_button=&category=search_setting';
Severity: Minor
Found in public/main/admin/course_request_edit.php by phpcodesniffer

Variable "course_validation_feature" is not in valid camel caps format
Open

if (!$course_validation_feature) {
Severity: Minor
Found in public/main/admin/course_request_edit.php by phpcodesniffer

Variable "course_request_info" is not in valid camel caps format
Open

        $values['tutor_name'] = $course_request_info['tutor_name'];
Severity: Minor
Found in public/main/admin/course_request_edit.php by phpcodesniffer

Variable "tool_name" is not in valid camel caps format
Open

        $form->addElement('header', $tool_name);
Severity: Minor
Found in public/main/admin/course_request_edit.php by phpcodesniffer

Variable "submit_buttons" is not in valid camel caps format
Open

            $submit_buttons[] = $form->addButtonPreview(get_lang('Ask for additional information'), 'ask_info_button', true);
Severity: Minor
Found in public/main/admin/course_request_edit.php by phpcodesniffer

Variable "course_request_info" is not in valid camel caps format
Open

        $values['directory'] = $course_request_info['directory'];
Severity: Minor
Found in public/main/admin/course_request_edit.php by phpcodesniffer

Variable "course_request_info" is not in valid camel caps format
Open

        $values['exemplary_content'] = $course_request_info['exemplary_content'];
Severity: Minor
Found in public/main/admin/course_request_edit.php by phpcodesniffer

Variable "course_request_info" is not in valid camel caps format
Open

            $course_code_ok = $course_request_values['wanted_code'] == $course_request_info['code']
Severity: Minor
Found in public/main/admin/course_request_edit.php by phpcodesniffer

Variable "course_request_values" is not in valid camel caps format
Open

                    $course_request_values['description'],
Severity: Minor
Found in public/main/admin/course_request_edit.php by phpcodesniffer

Variable "course_request_values" is not in valid camel caps format
Open

                                            $course_request_values['wanted_code']
Severity: Minor
Found in public/main/admin/course_request_edit.php by phpcodesniffer

Variable "submit_buttons" is not in valid camel caps format
Open

            $submit_buttons[] = $form->addButtonCancel(get_lang('Reject'), 'reject_button', true);
Severity: Minor
Found in public/main/admin/course_request_edit.php by phpcodesniffer

Variable "course_request_values" is not in valid camel caps format
Open

                    $course_request_values['category_code'],
Severity: Minor
Found in public/main/admin/course_request_edit.php by phpcodesniffer

Variable "course_request_values" is not in valid camel caps format
Open

                                            $course_request_values['wanted_code']
Severity: Minor
Found in public/main/admin/course_request_edit.php by phpcodesniffer

The variable $caller_id is not named in camelCase.
Open

function get_caller_name($caller_id)
{
    switch ($caller_id) {
        case 1:
            return 'course_request_accepted.php';
Severity: Minor
Found in public/main/admin/course_request_edit.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

There are no issues that match your filters.

Category
Status