public/main/ticket/priorities.php
Avoid unused parameters such as '$id'. Open
Open
function modify_filter($id, $params, $row)
- Read upRead up
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}
Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
Avoid unused parameters such as '$params'. Open
Open
function modify_filter($id, $params, $row)
- Read upRead up
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}
Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
Variable "this_section" is not in valid camel caps format Open
Open
$this_section = 'tickets';
- Exclude checks
Variable "per_page" is not in valid camel caps format Open
Open
if (0 == $table->per_page) {
- Exclude checks
Consider putting global function "modify_filter" in a static class Open
Open
function modify_filter($id, $params, $row)
- Exclude checks
Variable "per_page" is not in valid camel caps format Open
Open
$table->per_page = 20;
- Exclude checks
Variable "user_id" is not in valid camel caps format Open
Open
$user_id = api_get_user_id();
- Exclude checks