The method save() has an NPath complexity of 3456. The configured NPath complexity threshold is 200. Open
public function save($values, $file = [], $deleteFile = false)
{
$table = Database::get_main_table('session_rel_course_legal');
$courseId = $values['c_id'];- Read upRead up
- Exclude checks
NPathComplexity
Since: 0.1
The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.
Example
class Foo {
function bar() {
// lots of complicated code
}
}Source https://phpmd.org/rules/codesize.html#npathcomplexity
The method warnUsersByEmail uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$students = CourseManager::get_student_list_from_course_code($courseCode, true, $sessionId);
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
The method save uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$id = $legalData['id'];
$updateParams = [
'content' => $values['content'],- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
The property $course_settings is not named in camelCase. Open
class CourseLegalPlugin extends Plugin
{
public $isCoursePlugin = true;
// When creating a new course this settings are added to the course- Read upRead up
- Exclude checks
CamelCasePropertyName
Since: 0.2
It is considered best practice to use the camelCase notation to name attributes.
Example
class ClassName {
protected $property_name;
}Source
Missing function doc comment Open
public function install()- Exclude checks
Missing function doc comment Open
public function uninstall()- Exclude checks
Member variable "course_settings" is not in valid camel caps format Open
public $course_settings = [- Exclude checks
Variable "course_settings" is not in valid camel caps format Open
$this->uninstall_course_fields_in_all_courses($this->course_settings);- Exclude checks