Missing class import via use statement (line '189', column '17'). Open
new LtiNamesRoleProvisioningService($tool),- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '188', column '17'). Open
new LtiAssignmentGradesService($tool),- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}Source http://phpmd.org/rules/cleancode.html#MissingImport
The method generateClientId uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$char = substr($hash, mt_rand(0, strlen($hash) - 1), 1);
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
The method substituteVariablesInCustomParams uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
continue;
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
Doc comment for parameter $domain does not match actual variable name $course Open
* @param string $domain Optional. Institution domain.- Exclude checks
Doc comment for parameter $session does not match actual variable name $user Open
* @param Session|null $session Optional.- Exclude checks
Doc comment for parameter $session does not match actual variable name $user Open
* @param Session|null $session Optional.- Exclude checks
Doc comment for parameter $ltiVersion does not match actual variable name $session Open
* @param string $ltiVersion Optional. Default is lti1p1.- Exclude checks
Doc comment for parameter $domain does not match actual variable name $course Open
* @param string $domain Optional. Institution domain.- Exclude checks
Doc comment for parameter $ltiVersion does not match actual variable name $session Open
* @param string $ltiVersion Optional. Default is lti1p1.- Exclude checks
Doc comment for parameter $session does not match actual variable name $course Open
* @param Session $session Optional.- Exclude checks
Arguments with default values must be at the end of the argument list Open
ImsLtiTool $tool- Exclude checks
Arguments with default values must be at the end of the argument list Open
ImsLtiTool $tool- Exclude checks