chamilo/chamilo-lms

View on GitHub
public/plugin/questionoptionsevaluation/QuestionOptionsEvaluationPlugin.php

Summary

Maintainability
A
0 mins
Test Coverage

Missing class import via use statement (line '267', column '27').
Open

        $extraField = new ExtraField('quiz');

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '95', column '32').
Open

        $extraFieldValue = new ExtraFieldValue('quiz');

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '246', column '27').
Open

        $extraField = new ExtraField('quiz');

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '212', column '36').
Open

            $questionAnswers = new Answer($questionId, $exercise->course_id, $exercise);

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '112', column '32').
Open

        $extraFieldValue = new ExtraFieldValue('quiz');

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

The method recalculateQuestionScore uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

                } else {
                    $ponderation = 1 == $isCorrect ? 1 : -1 / $formula;
                }

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Variable "course_id" is not in valid camel caps format
Open

            $questionAnswers = new Answer($questionId, $exercise->course_id, $exercise);

Missing function doc comment
Open

    public function uninstall()

Missing function doc comment
Open

    public function install()

There are no issues that match your filters.

Category
Status