public/plugin/surveyexportcsv/export.php
The method otherRow uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
Open
} else {
$options = getQuestionOptions(
$user,
$courseId,
$question['survey_id'],- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
Consider putting global function "getSurveyAnswers" in a static class Open
Open
function getSurveyAnswers($courseId, $surveyId)- Exclude checks
Missing parameter name Open
Open
* @param $questions- Exclude checks
Consider putting global function "otherRow" in a static class Open
Open
function otherRow($questions, $user, $courseId)- Exclude checks
Consider putting global function "getOpenAnswer" in a static class Open
Open
function getOpenAnswer($questionId, $surveyId, $courseId, $user)- Exclude checks
Consider putting global function "getQuestionOptions" in a static class Open
Open
function getQuestionOptions($user, $courseId, $surveyId, $questionId)- Exclude checks
Consider putting global function "firstRow" in a static class Open
Open
function firstRow($questions)- Exclude checks