The method validate() has an NPath complexity of 432. The configured NPath complexity threshold is 200. Open
protected function validate(ParameterBag $query): void
{
$hasStatementId = $query->has('statementId');
$hasVoidedStatementId = $query->has('voidedStatementId');
- Read upRead up
- Exclude checks
NPathComplexity
Since: 0.1
The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.
Example
class Foo {
function bar() {
// lots of complicated code
}
}Source https://phpmd.org/rules/codesize.html#npathcomplexity
The class StatementGetController has a coupling between objects value of 18. Consider to reduce the number of dependencies under 13. Open
class StatementGetController
{
protected static array $getParameters = [
'statementId' => true,
'voidedStatementId' => true,- Read upRead up
- Exclude checks
CouplingBetweenObjects
Since: 1.1.0
A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability
Example
class Foo {
/**
* @var \foo\bar\X
*/
private $x = null;
/**
* @var \foo\bar\Y
*/
private $y = null;
/**
* @var \foo\bar\Z
*/
private $z = null;
public function setFoo(\Foo $foo) {}
public function setBar(\Bar $bar) {}
public function setBaz(\Baz $baz) {}
/**
* @return \SplObjectStorage
* @throws \OutOfRangeException
* @throws \InvalidArgumentException
* @throws \ErrorException
*/
public function process(\Iterator $it) {}
// ...
}Source https://phpmd.org/rules/design.html#couplingbetweenobjects
Avoid assigning values to variables in if clauses and the like (line '81', column '18'). Open
public function getStatement(Request $request)
{
$query = new ParameterBag(array_intersect_key($request->query->all(), self::$getParameters));
$this->validate($query);- Read upRead up
- Exclude checks
IfStatementAssignment
Since: 2.7.0
Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.
Example
class Foo
{
public function bar($flag)
{
if ($foo = 'bar') { // possible typo
// ...
}
if ($baz = 0) { // always false
// ...
}
}
}Source http://phpmd.org/rules/cleancode.html#ifstatementassignment
Avoid assigning values to variables in if clauses and the like (line '85', column '24'). Open
public function getStatement(Request $request)
{
$query = new ParameterBag(array_intersect_key($request->query->all(), self::$getParameters));
$this->validate($query);- Read upRead up
- Exclude checks
IfStatementAssignment
Since: 2.7.0
Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.
Example
class Foo
{
public function bar($flag)
{
if ($foo = 'bar') { // possible typo
// ...
}
if ($baz = 0) { // always false
// ...
}
}
}Source http://phpmd.org/rules/cleancode.html#ifstatementassignment
The method getStatement uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$statements = $this->repository->findStatementsBy($this->statementsFilterFactory->createFromParameterBag($query));
$response = $this->buildMultiStatementsResponse($statements, $query, $includeAttachments);
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
Missing function doc comment Open
public function __construct(- Exclude checks
Add a single space around assignment operators Open
declare(strict_types=1);- Exclude checks
Closing brace must be on a line by itself Open
) {}- Exclude checks
Line indented incorrectly; expected 4 spaces, found 8 Open
protected readonly StatementSerializerInterface $statementSerializer,- Exclude checks
Closing brace must be on a line by itself Open
) {}- Exclude checks
Line indented incorrectly; expected 4 spaces, found 8 Open
protected readonly StatementRepositoryInterface $repository,- Exclude checks
Line indented incorrectly; expected 4 spaces, found 8 Open
protected readonly StatementResultSerializerInterface $statementResultSerializer,- Exclude checks
Line indented incorrectly; expected 4 spaces, found 8 Open
protected readonly StatementsFilterFactory $statementsFilterFactory- Exclude checks