public/plugin/xapi/php-xapi/lrs-bundle/src/Controller/StatementPostController.php
Avoid unused local variables such as '$statementId'. Open
Open
if (null === $statementId = $statement->getId()) {- Read upRead up
- Exclude checks
UnusedLocalVariable
Since: 0.2
Detects when a local variable is declared and/or assigned, but not used.
Example
class Foo {
public function doSomething()
{
$i = 5; // Unused
}
}Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable
Avoid unused parameters such as '$request'. Open
Open
public function postStatements(Request $request, array $statements): JsonResponse- Read upRead up
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
Avoid assigning values to variables in if clauses and the like (line '44', column '26'). Open
Open
public function postStatements(Request $request, array $statements): JsonResponse
{
$statementsToStore = [];
/** @var Statement $statement */- Read upRead up
- Exclude checks
IfStatementAssignment
Since: 2.7.0
Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.
Example
class Foo
{
public function bar($flag)
{
if ($foo = 'bar') { // possible typo
// ...
}
if ($baz = 0) { // always false
// ...
}
}
}Source http://phpmd.org/rules/cleancode.html#ifstatementassignment
Add a single space around assignment operators Open
Open
declare(strict_types=1);- Exclude checks
Missing function doc comment Open
Open
public function postStatements(Request $request, array $statements): JsonResponse- Exclude checks
Missing function doc comment Open
Open
public function __construct(StatementRepositoryInterface $repository)- Exclude checks