public/plugin/xapi/src/Lrs/StatementsController.php
The class StatementsController has a coupling between objects value of 17. Consider to reduce the number of dependencies under 13. Open
Open
class StatementsController extends BaseController
{
/**
* @var StatementRepository
*/- Read upRead up
- Exclude checks
CouplingBetweenObjects
Since: 1.1.0
A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability
Example
class Foo {
/**
* @var \foo\bar\X
*/
private $x = null;
/**
* @var \foo\bar\Y
*/
private $y = null;
/**
* @var \foo\bar\Z
*/
private $z = null;
public function setFoo(\Foo $foo) {}
public function setBar(\Bar $bar) {}
public function setBaz(\Baz $baz) {}
/**
* @return \SplObjectStorage
* @throws \OutOfRangeException
* @throws \InvalidArgumentException
* @throws \ErrorException
*/
public function process(\Iterator $it) {}
// ...
}Source https://phpmd.org/rules/design.html#couplingbetweenobjects
Avoid using empty try-catch blocks in saveLog. Open
Open
} catch (NotFoundException $e) {
}- Read upRead up
- Exclude checks
EmptyCatchBlock
Since: 2.7.0
Usually empty try-catch is a bad idea because you are silently swallowing an error condition and then continuing execution. Occasionally this may be the right thing to do, but often it's a sign that a developer saw an exception, didn't know what to do about it, and so used an empty catch to silence the problem.
Example
class Foo {
public function bar()
{
try {
// ...
} catch (Exception $e) {} // empty catch block
}
}Source https://phpmd.org/rules/design.html#emptycatchblock
Missing function doc comment Open
Open
public function __construct(Request $httpRequest)- Exclude checks
Add a single space around assignment operators Open
Open
declare(strict_types=1);- Exclude checks
Missing function doc comment Open
Open
public function head(): Response- Exclude checks
Missing function doc comment Open
Open
public function get(): Response- Exclude checks
Missing function doc comment Open
Open
public function post(): Response- Exclude checks
Missing function doc comment Open
Open
public function put(): Response- Exclude checks