The class XApiPlugin has a coupling between objects value of 50. Consider to reduce the number of dependencies under 13. Open
class XApiPlugin extends Plugin implements HookPluginInterface
{
public const SETTING_LRS_URL = 'lrs_url';
public const SETTING_LRS_AUTH_USERNAME = 'lrs_auth_username';
public const SETTING_LRS_AUTH_PASSWORD = 'lrs_auth_password';- Read upRead up
- Exclude checks
CouplingBetweenObjects
Since: 1.1.0
A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability
Example
class Foo {
/**
* @var \foo\bar\X
*/
private $x = null;
/**
* @var \foo\bar\Y
*/
private $y = null;
/**
* @var \foo\bar\Z
*/
private $z = null;
public function setFoo(\Foo $foo) {}
public function setBar(\Bar $bar) {}
public function setBaz(\Baz $baz) {}
/**
* @return \SplObjectStorage
* @throws \OutOfRangeException
* @throws \InvalidArgumentException
* @throws \ErrorException
*/
public function process(\Iterator $it) {}
// ...
}Source https://phpmd.org/rules/design.html#couplingbetweenobjects
The method performActionsAfterConfigure uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$quizQuestionAnsweredEvent->detach($quizQuestionAnsweredHook);
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
The method performActionsAfterConfigure uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$quizEndEvent->detach($quizEndHook);
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
The method performActionsAfterConfigure uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$learningPathItemViewedEvent->detach($learningPathItemViewedHook);
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
The method performActionsAfterConfigure uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$portfolioItemAddedEvent->detach($portfolioItemAddedHook);
$portfolioItemCommentedEvent->detach($portfolioItemCommentedHook);
$portfolioItemViewedEvent->detach($portfolioItemViewedHook);
$portfolioItemHighlightedEvent->detach($portfolioItemHighlightedHook);- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
The method performActionsAfterConfigure uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$learningPathEndEvent->detach($learningPathEndHook);
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
Doc comment for parameter $needle does not match actual variable name $haystack Open
* @param string $needle- Exclude checks
Missing function doc comment Open
public function getXApiStatementClient(): StatementsApiClientInterface- Exclude checks
Missing function doc comment Open
public function getLpResourceBlock(int $lpId)- Exclude checks
Doc comment for parameter $language does not match actual variable name $languageMap Open
* @param string $language- Exclude checks
Missing function doc comment Open
public function getXapiStatementCronClient(): StatementsApiClientInterface- Exclude checks
Missing function doc comment Open
public function generateLaunchUrl(- Exclude checks