The class AccountController has a coupling between objects value of 15. Consider to reduce the number of dependencies under 13. Open
class AccountController extends BaseController
{
use ControllerTrait;
public function __construct(- Read upRead up
- Exclude checks
CouplingBetweenObjects
Since: 1.1.0
A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability
Example
class Foo {
/**
* @var \foo\bar\X
*/
private $x = null;
/**
* @var \foo\bar\Y
*/
private $y = null;
/**
* @var \foo\bar\Z
*/
private $z = null;
public function setFoo(\Foo $foo) {}
public function setBar(\Bar $bar) {}
public function setBaz(\Baz $baz) {}
/**
* @return \SplObjectStorage
* @throws \OutOfRangeException
* @throws \InvalidArgumentException
* @throws \ErrorException
*/
public function process(\Iterator $it) {}
// ...
}Source https://phpmd.org/rules/design.html#couplingbetweenobjects
The method changePassword uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$user->setPlainPassword($newPassword);
$userRepository->updateUser($user);
$this->addFlash('success', $this->translator->trans('Password changed successfully.'));
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
The method changePassword uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$errors = $this->validatePassword($newPassword);
if (\count($errors) > 0) {
foreach ($errors as $error) {
$form->get('newPassword')->addError(new FormError($error));- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
The method changePassword uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$currentPassword = $form->get('currentPassword')->getData();
$newPassword = $form->get('newPassword')->getData();
$confirmPassword = $form->get('confirmPassword')->getData();
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
Perl-style comments are not allowed. Use "// Comment." or "/* comment */" instead. Open
#[Route('/account')]- Exclude checks
You must use "/**" style comments for a function comment Open
public function edit(Request $request, UserRepository $userRepository, IllustrationRepository $illustrationRepo, SettingsManager $settingsManager): Response- Exclude checks
You must use "/**" style comments for a class comment Open
class AccountController extends BaseController- Exclude checks
Perl-style comments are not allowed. Use "// Comment." or "/* comment */" instead. Open
#[Route('/edit', name: 'chamilo_core_account_edit', methods: ['GET', 'POST'])]- Exclude checks
Add a single space around assignment operators Open
declare(strict_types=1);- Exclude checks
Closing brace must be on a line by itself Open
) {}- Exclude checks
Missing function doc comment Open
public function __construct(- Exclude checks
Perl-style comments are not allowed. Use "// Comment." or "/* comment */" instead. Open
#[Route('/change-password', name: 'chamilo_core_account_change_password', methods: ['GET', 'POST'])]- Exclude checks
You must use "/**" style comments for a function comment Open
public function changePassword(Request $request, UserRepository $userRepository, CsrfTokenManagerInterface $csrfTokenManager): Response- Exclude checks
Line indented incorrectly; expected 4 spaces, found 8 Open
private readonly TranslatorInterface $translator- Exclude checks
Line indented incorrectly; expected 4 spaces, found 8 Open
private readonly UserHelper $userHelper,- Exclude checks
Closing brace must be on a line by itself Open
) {}- Exclude checks