Sign upLogin

chamilo/chamilo-lms

View on GitHub
Star
src/CoreBundle/Controller/Api/UpdatePositionLink.php

Summary

Maintainability
A
0 mins
Test Coverage

Avoid unused local variables such as '$newPosition'.
Open

        $newPosition = (int) $requestData['position'];
Severity: Minor
Found in src/CoreBundle/Controller/Api/UpdatePositionLink.php by phpmd

UnusedLocalVariable

Since: 0.2

Detects when a local variable is declared and/or assigned, but not used.

Example

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

Avoid unused parameters such as '$repo'.
Open

    public function __invoke(CLink $link, CLinkRepository $repo, Request $request, EntityManager $em): CLink
Severity: Minor
Found in src/CoreBundle/Controller/Api/UpdatePositionLink.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

You must use "/**" style comments for a class comment
Open

class UpdatePositionLink extends AbstractController
Severity: Minor
Found in src/CoreBundle/Controller/Api/UpdatePositionLink.php by phpcodesniffer

Add a single space around assignment operators
Open

declare(strict_types=1);
Severity: Minor
Found in src/CoreBundle/Controller/Api/UpdatePositionLink.php by phpcodesniffer

Missing function doc comment
Open

    public function __invoke(CLink $link, CLinkRepository $repo, Request $request, EntityManager $em): CLink
Severity: Minor
Found in src/CoreBundle/Controller/Api/UpdatePositionLink.php by phpcodesniffer

Perl-style comments are not allowed. Use "// Comment." or "/* comment */" instead.
Open

#[AsController]
Severity: Minor
Found in src/CoreBundle/Controller/Api/UpdatePositionLink.php by phpcodesniffer

There are no issues that match your filters.

Category
Status