src/CoreBundle/Controller/SecurityController.php
The method loginJson() has an NPath complexity of 252. The configured NPath complexity threshold is 200. Open
Open
public function loginJson(Request $request, EntityManager $entityManager, SettingsManager $settingsManager, TokenStorageInterface $tokenStorage, TranslatorInterface $translator): Response
{
if (!$this->isGranted('IS_AUTHENTICATED_FULLY')) {
return $this->json(
[- Read upRead up
- Exclude checks
NPathComplexity
Since: 0.1
The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.
Example
class Foo {
function bar() {
// lots of complicated code
}
}Source https://phpmd.org/rules/codesize.html#npathcomplexity
The class SecurityController has a coupling between objects value of 15. Consider to reduce the number of dependencies under 13. Open
Open
class SecurityController extends AbstractController
{
public function __construct(
private SerializerInterface $serializer,
private TrackELoginRecordRepository $trackELoginRecordRepository,- Read upRead up
- Exclude checks
CouplingBetweenObjects
Since: 1.1.0
A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability
Example
class Foo {
/**
* @var \foo\bar\X
*/
private $x = null;
/**
* @var \foo\bar\Y
*/
private $y = null;
/**
* @var \foo\bar\Z
*/
private $z = null;
public function setFoo(\Foo $foo) {}
public function setBar(\Bar $bar) {}
public function setBaz(\Baz $baz) {}
/**
* @return \SplObjectStorage
* @throws \OutOfRangeException
* @throws \InvalidArgumentException
* @throws \ErrorException
*/
public function process(\Iterator $it) {}
// ...
}Source https://phpmd.org/rules/design.html#couplingbetweenobjects
The method loginJson uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
Open
} else {
$message = $translator->trans('Invalid credentials. Please try again or contact support if you continue to experience issues.');
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid unused parameters such as '$entityManager'. Open
Open
public function loginJson(Request $request, EntityManager $entityManager, SettingsManager $settingsManager, TokenStorageInterface $tokenStorage, TranslatorInterface $translator): Response- Read upRead up
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
Avoid unused parameters such as '$settingsManager'. Open
Open
public function loginJson(Request $request, EntityManager $entityManager, SettingsManager $settingsManager, TokenStorageInterface $tokenStorage, TranslatorInterface $translator): Response- Read upRead up
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
Closing brace must be on a line by itself Open
Open
) {}- Exclude checks
Missing function doc comment Open
Open
public function __construct(- Exclude checks
You must use "/**" style comments for a function comment Open
Open
public function loginJson(Request $request, EntityManager $entityManager, SettingsManager $settingsManager, TokenStorageInterface $tokenStorage, TranslatorInterface $translator): Response- Exclude checks
Perl-style comments are not allowed. Use "// Comment." or "/* comment */" instead. Open
Open
#[Route('/login_json', name: 'login_json', methods: ['POST'])]- Exclude checks
You must use "/**" style comments for a function comment Open
Open
public function checkSession(): JsonResponse- Exclude checks
Missing class doc comment Open
Open
class SecurityController extends AbstractController- Exclude checks
Add a single space around assignment operators Open
Open
declare(strict_types=1);- Exclude checks
Perl-style comments are not allowed. Use "// Comment." or "/* comment */" instead. Open
Open
#[Route('/check-session', name: 'check_session', methods: ['GET'])]- Exclude checks
Line indented incorrectly; expected 4 spaces, found 8 Open
Open
private TokenStorageInterface $tokenStorage,- Exclude checks
Line indented incorrectly; expected 4 spaces, found 8 Open
Open
private SettingsManager $settingsManager,- Exclude checks
Line indented incorrectly; expected 4 spaces, found 8 Open
Open
private readonly UserHelper $userHelper,- Exclude checks
Line indented incorrectly; expected 4 spaces, found 8 Open
Open
private TrackELoginRecordRepository $trackELoginRecordRepository,- Exclude checks
Line indented incorrectly; expected 4 spaces, found 8 Open
Open
private EntityManagerInterface $entityManager,- Exclude checks
Line indented incorrectly; expected 4 spaces, found 8 Open
Open
private SerializerInterface $serializer,- Exclude checks
Line indented incorrectly; expected 4 spaces, found 8 Open
Open
private AuthorizationCheckerInterface $authorizationChecker,- Exclude checks
Closing brace must be on a line by itself Open
Open
) {}- Exclude checks