src/CoreBundle/DataProvider/Extension/CCalendarEventExtension.php
The class CCalendarEventExtension has a coupling between objects value of 14. Consider to reduce the number of dependencies under 13. Open
Open
final class CCalendarEventExtension implements QueryCollectionExtensionInterface
{
public function __construct(
private readonly CidReqHelper $cidReqHelper,
private readonly UserHelper $userHelper,- Read upRead up
- Exclude checks
CouplingBetweenObjects
Since: 1.1.0
A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability
Example
class Foo {
/**
* @var \foo\bar\X
*/
private $x = null;
/**
* @var \foo\bar\Y
*/
private $y = null;
/**
* @var \foo\bar\Z
*/
private $z = null;
public function setFoo(\Foo $foo) {}
public function setBar(\Bar $bar) {}
public function setBaz(\Baz $baz) {}
/**
* @return \SplObjectStorage
* @throws \OutOfRangeException
* @throws \InvalidArgumentException
* @throws \ErrorException
*/
public function process(\Iterator $it) {}
// ...
}Source https://phpmd.org/rules/design.html#couplingbetweenobjects
The method addSessionConditions uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
Open
} else {
$sessions = $this->sessionRepository->getSessionsByUser($user, $accessUrl)->getQuery()->getResult();
foreach ($sessions as $session) {
foreach ($session->getSessionRelCourseByUser($user) as $sessionRelCourse) {- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid unused parameters such as '$queryNameGenerator'. Open
Open
QueryNameGeneratorInterface $queryNameGenerator,- Read upRead up
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
Avoid unused local variables such as '$groupId'. Open
Open
$groupId = $this->cidReqHelper->getGroupId();- Read upRead up
- Exclude checks
UnusedLocalVariable
Since: 0.2
Detects when a local variable is declared and/or assigned, but not used.
Example
class Foo {
public function doSomething()
{
$i = 5; // Unused
}
}Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable
Avoid unused parameters such as '$operation'. Open
Open
?Operation $operation = null,- Read upRead up
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
Missing class doc comment Open
Open
final class CCalendarEventExtension implements QueryCollectionExtensionInterface- Exclude checks
Closing brace must be on a line by itself Open
Open
) {}- Exclude checks
Missing function doc comment Open
Open
public function applyToCollection(- Exclude checks
Missing function doc comment Open
Open
public function __construct(- Exclude checks
Add a single space around assignment operators Open
Open
declare(strict_types=1);- Exclude checks
Line indented incorrectly; expected 4 spaces, found 8 Open
Open
private readonly UserHelper $userHelper,- Exclude checks
Line indented incorrectly; expected 4 spaces, found 8 Open
Open
private readonly AccessUrlHelper $accessUrlHelper,- Exclude checks
Line indented incorrectly; expected 4 spaces, found 8 Open
Open
private readonly SettingsManager $settingsManager,- Exclude checks
Line indented incorrectly; expected 4 spaces, found 8 Open
Open
private readonly SessionRepository $sessionRepository,- Exclude checks
Line indented incorrectly; expected 4 spaces, found 8 Open
Open
private readonly CidReqHelper $cidReqHelper,- Exclude checks
Line indented incorrectly; expected 4 spaces, found 8 Open
Open
private readonly CourseRepository $courseRepository,- Exclude checks
Closing brace must be on a line by itself Open
Open
) {}- Exclude checks