Avoid unused parameters such as '$operation'. Open
?Operation $operation = null,- Read upRead up
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
Avoid unused parameters such as '$queryNameGenerator'. Open
QueryNameGeneratorInterface $queryNameGenerator,- Read upRead up
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
Avoid unused parameters such as '$context'. Open
array $context = []- Read upRead up
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
Avoid assigning values to variables in if clauses and the like (line '59', column '22'). Open
private function addWhere(QueryBuilder $queryBuilder, string $resourceClass): void
{
if (PersonalFile::class !== $resourceClass) {
return;
}- Read upRead up
- Exclude checks
IfStatementAssignment
Since: 2.7.0
Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.
Example
class Foo
{
public function bar($flag)
{
if ($foo = 'bar') { // possible typo
// ...
}
if ($baz = 0) { // always false
// ...
}
}
}Source http://phpmd.org/rules/cleancode.html#ifstatementassignment
The method addWhere uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$queryBuilder->orWhere('node.creator = :current');
$queryBuilder->setParameter('current', $user->getId());
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
Closing brace must be on a line by itself Open
) {}- Exclude checks
Missing function doc comment Open
public function applyToCollection(- Exclude checks
Add a single space around assignment operators Open
declare(strict_types=1);- Exclude checks
Missing function doc comment Open
public function __construct(- Exclude checks
Closing brace must be on a line by itself Open
) {}- Exclude checks
Line indented incorrectly; expected 4 spaces, found 8 Open
private readonly Security $security,- Exclude checks
Line indented incorrectly; expected 4 spaces, found 8 Open
private readonly RequestStack $requestStack- Exclude checks