Sign upLogin

chamilo/chamilo-lms

View on GitHub
Star
src/CoreBundle/DataProvider/Extension/SessionRelUserExtension.php

Summary

Maintainability
A
0 mins
Test Coverage

Avoid assigning values to variables in if clauses and the like (line '57', column '22').
Open

    private function addWhere(QueryBuilder $qb, string $resourceClass): void
    {
        if (SessionRelUser::class !== $resourceClass) {
            return;
        }
Severity: Minor
Found in src/CoreBundle/DataProvider/Extension/SessionRelUserExtension.php by phpmd

IfStatementAssignment

Since: 2.7.0

Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

Example

class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

Avoid unused parameters such as '$operation'.
Open

        ?Operation $operation = null,
Severity: Minor
Found in src/CoreBundle/DataProvider/Extension/SessionRelUserExtension.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$context'.
Open

        array $context = []
Severity: Minor
Found in src/CoreBundle/DataProvider/Extension/SessionRelUserExtension.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$queryNameGenerator'.
Open

        QueryNameGeneratorInterface $queryNameGenerator,
Severity: Minor
Found in src/CoreBundle/DataProvider/Extension/SessionRelUserExtension.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Missing function doc comment
Open

    public function applyToCollection(
Severity: Minor
Found in src/CoreBundle/DataProvider/Extension/SessionRelUserExtension.php by phpcodesniffer

Add a single space around assignment operators
Open

declare(strict_types=1);
Severity: Minor
Found in src/CoreBundle/DataProvider/Extension/SessionRelUserExtension.php by phpcodesniffer

You must use "/**" style comments for a class comment
Open

final class SessionRelUserExtension implements QueryCollectionExtensionInterface // , QueryItemExtensionInterface
Severity: Minor
Found in src/CoreBundle/DataProvider/Extension/SessionRelUserExtension.php by phpcodesniffer

Missing function doc comment
Open

    public function __construct(
Severity: Minor
Found in src/CoreBundle/DataProvider/Extension/SessionRelUserExtension.php by phpcodesniffer

Closing brace must be on a line by itself
Open

    ) {}
Severity: Minor
Found in src/CoreBundle/DataProvider/Extension/SessionRelUserExtension.php by phpcodesniffer

Line indented incorrectly; expected 4 spaces, found 8
Open

        private readonly Security $security,
Severity: Minor
Found in src/CoreBundle/DataProvider/Extension/SessionRelUserExtension.php by phpcodesniffer

Closing brace must be on a line by itself
Open

    ) {}
Severity: Minor
Found in src/CoreBundle/DataProvider/Extension/SessionRelUserExtension.php by phpcodesniffer

There are no issues that match your filters.

Category
Status