src/CoreBundle/Migrations/Schema/V200/Version20181025064351.php
The method up() has an NPath complexity of 450359962737049600. The configured NPath complexity threshold is 200. Open
Open
public function up(Schema $schema): void
{
$table = $schema->getTable('gradebook_result_log');
if ($table->hasColumn('id_result')) {
$this->addSql('DELETE FROM gradebook_result_log WHERE id_result IS NULL');- Read upRead up
- Exclude checks
NPathComplexity
Since: 0.1
The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.
Example
class Foo {
function bar() {
// lots of complicated code
}
}Source https://phpmd.org/rules/codesize.html#npathcomplexity
The method up uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
Open
} else {
$table = $schema->getTable('gradebook_result_attempt');
$this->addSql('UPDATE gradebook_result_attempt SET result_id = NULL WHERE result_id = 0');
$this->addSql('ALTER TABLE gradebook_result_attempt CHANGE result_id result_id INT DEFAULT NULL');
if (!$table->hasForeignKey('FK_28B1CC3F7A7B643')) {- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid unused parameters such as '$schema'. Open
Open
public function down(Schema $schema): void {}- Read upRead up
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
Missing function doc comment Open
Open
public function getDescription(): string- Exclude checks
Add a single space around assignment operators Open
Open
declare(strict_types=1);- Exclude checks
Missing function doc comment Open
Open
public function up(Schema $schema): void- Exclude checks
Missing class doc comment Open
Open
class Version20181025064351 extends AbstractMigrationChamilo- Exclude checks
Closing brace must be on a line by itself Open
Open
public function down(Schema $schema): void {}- Exclude checks
Missing function doc comment Open
Open
public function down(Schema $schema): void {}- Exclude checks
Closing brace must be on a line by itself Open
Open
public function down(Schema $schema): void {}- Exclude checks
Opening brace should be on a new line Open
Open
public function down(Schema $schema): void {}- Exclude checks