The method up uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
if (!$table->hasForeignKey('FK_E4A3EAD4B58CDA09')) {
$this->addSql('ALTER TABLE sys_announcement ADD CONSTRAINT FK_E4A3EAD4B58CDA09 FOREIGN KEY (career_id) REFERENCES career (id) ON DELETE CASCADE');
}
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
The method up uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
if (!$table->hasForeignKey('FK_E4A3EAD4139DF194')) {
$this->addSql('ALTER TABLE sys_announcement ADD CONSTRAINT FK_E4A3EAD4139DF194 FOREIGN KEY (promotion_id) REFERENCES promotion (id) ON DELETE CASCADE');
}
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid unused parameters such as '$schema'. Open
public function down(Schema $schema): void {}- Read upRead up
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
Missing function doc comment Open
public function down(Schema $schema): void {}- Exclude checks
Missing function doc comment Open
public function getDescription(): string- Exclude checks
Closing brace must be on a line by itself Open
public function down(Schema $schema): void {}- Exclude checks
Missing class doc comment Open
final class Version20200922224343 extends AbstractMigrationChamilo- Exclude checks
Add a single space around assignment operators Open
declare(strict_types=1);- Exclude checks
Missing function doc comment Open
public function up(Schema $schema): void- Exclude checks
Opening brace should be on a new line Open
public function down(Schema $schema): void {}- Exclude checks
Closing brace must be on a line by itself Open
public function down(Schema $schema): void {}- Exclude checks