src/CoreBundle/Migrations/Schema/V200/Version20201215072917.php
The method up uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
Open
} else {
$this->addSql(
"UPDATE settings SET selected_value = '$selectedValue' WHERE variable = 'allow_careers_in_global_agenda'"
);
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
Missing function doc comment Open
Open
public function getDescription(): string- Exclude checks
Missing function doc comment Open
Open
public function up(Schema $schema): void- Exclude checks
Missing class doc comment Open
Open
class Version20201215072917 extends AbstractMigrationChamilo- Exclude checks
Add a single space around assignment operators Open
Open
declare(strict_types=1);- Exclude checks
Missing function doc comment Open
Open
public function down(Schema $schema): void- Exclude checks
Declare public methods first,then protected ones and finally private ones Open
Open
public function down(Schema $schema): void- Exclude checks
The variable $_configuration is not named in camelCase. Open
Open
private function getConfigurationSelectedValue(): string
{
global $_configuration;
$updateRootPath = $this->getUpdateRootPath();
$oldConfigPath = $updateRootPath.'/app/config/configuration.php';- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $_configuration is not named in camelCase. Open
Open
private function getConfigurationSelectedValue(): string
{
global $_configuration;
$updateRootPath = $this->getUpdateRootPath();
$oldConfigPath = $updateRootPath.'/app/config/configuration.php';- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}