The method up() has an NPath complexity of 262144. The configured NPath complexity threshold is 200. Open
public function up(Schema $schema): void
{
$configurationValues = SettingsCurrentFixtures::getNewConfigurationSettings();
foreach ($configurationValues as $category => $settings) {- Read upRead up
- Exclude checks
NPathComplexity
Since: 0.1
The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.
Example
class Foo {
function bar() {
// lots of complicated code
}
}Source https://phpmd.org/rules/codesize.html#npathcomplexity
The method down() has an NPath complexity of 2048. The configured NPath complexity threshold is 200. Open
public function down(Schema $schema): void
{
$configurationValues = SettingsCurrentFixtures::getNewConfigurationSettings();
foreach ($configurationValues as $category => $settings) {- Read upRead up
- Exclude checks
NPathComplexity
Since: 0.1
The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.
Example
class Foo {
function bar() {
// lots of complicated code
}
}Source https://phpmd.org/rules/codesize.html#npathcomplexity
The method getConfigurationSelectedValue uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$selectedValue = (string) $settingValue;
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
The method up uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$this->addSql(
"UPDATE settings SET selected_value = '{$selectedValue}', category = '{$category}' WHERE variable = '$variable' AND category = '{$category}'"
);
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid unused parameters such as '$schema'. Open
public function up(Schema $schema): void- Read upRead up
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
Avoid unused parameters such as '$schema'. Open
public function down(Schema $schema): void- Read upRead up
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
Avoid unused local variables such as '$kernel'. Open
$kernel = $this->container->get('kernel');- Read upRead up
- Exclude checks
UnusedLocalVariable
Since: 0.2
Detects when a local variable is declared and/or assigned, but not used.
Example
class Foo {
public function doSomething()
{
$i = 5; // Unused
}
}Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable
Missing function doc comment Open
public function getDescription(): string- Exclude checks
Missing class doc comment Open
class Version20230216122900 extends AbstractMigrationChamilo- Exclude checks
Missing function doc comment Open
public function down(Schema $schema): void- Exclude checks
Missing function doc comment Open
public function getConfigurationSelectedValue(string $variable): string- Exclude checks
Missing function doc comment Open
public function up(Schema $schema): void- Exclude checks
Add a single space around assignment operators Open
declare(strict_types=1);- Exclude checks
The variable $_configuration is not named in camelCase. Open
public function getConfigurationSelectedValue(string $variable): string
{
global $_configuration;
$kernel = $this->container->get('kernel');
$oldConfigPath = $this->getUpdateRootPath().'/app/config/configuration.php';- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $_configuration is not named in camelCase. Open
public function getConfigurationSelectedValue(string $variable): string
{
global $_configuration;
$kernel = $this->container->get('kernel');
$oldConfigPath = $this->getUpdateRootPath().'/app/config/configuration.php';- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}