chamilo/chamilo-lms

View on GitHub
src/CoreBundle/Migrations/Schema/V200/Version20240416110300.php

Summary

Maintainability
A
0 mins
Test Coverage

The method up uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

            } else {
                // Update existing field
                $this->connection->update('extra_field', [
                    'display_text' => $field['display_text'],
                    'visible_to_self' => isset($field['visible_to_self']) ? (int) $field['visible_to_self'] : 0,

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid unused parameters such as '$schema'.
Open

    public function down(Schema $schema): void {}

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$schema'.
Open

    public function up(Schema $schema): void

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Missing function doc comment
Open

    public function up(Schema $schema): void

Missing function doc comment
Open

    public function down(Schema $schema): void {}

Missing function doc comment
Open

    public function getDescription(): string

Missing class doc comment
Open

class Version20240416110300 extends AbstractMigrationChamilo

Multi-line function call not indented correctly; expected 20 spaces but found 16
Open

                ], [

Add a single space around assignment operators
Open

declare(strict_types=1);

Closing brace must be on a line by itself
Open

    public function down(Schema $schema): void {}

Opening brace should be on a new line
Open

    public function down(Schema $schema): void {}

Closing brace must be on a line by itself
Open

    public function down(Schema $schema): void {}

There are no issues that match your filters.

Category
Status