src/CoreBundle/Migrations/Schema/V200/Version20240519210000.php
Avoid unused parameters such as '$schema'. Open
Open
public function up(Schema $schema): void- Read upRead up
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
Avoid unused parameters such as '$schema'. Open
Open
public function down(Schema $schema): void- Read upRead up
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
Avoid unused local variables such as '$kernel'. Open
Open
$kernel = $this->container->get('kernel');- Read upRead up
- Exclude checks
UnusedLocalVariable
Since: 0.2
Detects when a local variable is declared and/or assigned, but not used.
Example
class Foo {
public function doSomething()
{
$i = 5; // Unused
}
}Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable
The method up uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
Open
} else {
error_log('MIGRATIONS :: File not found for pattern: '.$pathPattern);
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
Missing function doc comment Open
Open
public function down(Schema $schema): void- Exclude checks
Missing class doc comment Open
Open
final class Version20240519210000 extends AbstractMigrationChamilo- Exclude checks
Declare public methods first,then protected ones and finally private ones Open
Open
public function down(Schema $schema): void- Exclude checks
Missing function doc comment Open
Open
public function getDescription(): string- Exclude checks
Missing function doc comment Open
Open
public function up(Schema $schema): void- Exclude checks
Add a single space around assignment operators Open
Open
declare(strict_types=1);- Exclude checks