Sign upLogin

chamilo/chamilo-lms

View on GitHub
Star
src/CoreBundle/Repository/ExtraFieldValuesRepository.php

Summary

Maintainability
A
0 mins
Test Coverage

The method updateItemData uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            $extraFieldValues->setFieldValue($data);
            $em->persist($extraFieldValues);
        }
Severity: Minor
Found in src/CoreBundle/Repository/ExtraFieldValuesRepository.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method findByVariableAndValue uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            $qb->andWhere($qb->expr()->eq('s.fieldValue', ':value'));
        }
Severity: Minor
Found in src/CoreBundle/Repository/ExtraFieldValuesRepository.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Add a single space around assignment operators
Open

declare(strict_types=1);
Severity: Minor
Found in src/CoreBundle/Repository/ExtraFieldValuesRepository.php by phpcodesniffer

Missing function doc comment
Open

    public function __construct(ManagerRegistry $registry)
Severity: Minor
Found in src/CoreBundle/Repository/ExtraFieldValuesRepository.php by phpcodesniffer

Missing function doc comment
Open

    public function updateItemData(ExtraField $extraField, ExtraFieldItemInterface $item, ?string $data): ?ExtraFieldValues
Severity: Minor
Found in src/CoreBundle/Repository/ExtraFieldValuesRepository.php by phpcodesniffer

Missing function doc comment
Open

    public function findLegalAcceptByItemId($itemId)
Severity: Minor
Found in src/CoreBundle/Repository/ExtraFieldValuesRepository.php by phpcodesniffer

Arguments with default values must be at the end of the argument list
Open

        bool $useLike = false,
Severity: Minor
Found in src/CoreBundle/Repository/ExtraFieldValuesRepository.php by phpcodesniffer

There are no issues that match your filters.

Category
Status