src/CoreBundle/Repository/Node/IllustrationRepository.php
The method addIllustration uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
Open
} else {
$illustration = $this->findOneBy([
'resourceNode' => $illustrationNode,
]);
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
Missing function doc comment Open
Open
public function hasIllustration(ResourceIllustrationInterface $resource): bool- Exclude checks
Missing function doc comment Open
Open
public function deleteIllustration(ResourceInterface $resource): void- Exclude checks
Missing function doc comment Open
Open
public function __construct(ManagerRegistry $registry)- Exclude checks
Missing function doc comment Open
Open
public function getIllustrationNodeFromParent(ResourceNode $resourceNode): ?ResourceNode- Exclude checks
Missing class doc comment Open
Open
final class IllustrationRepository extends ResourceRepository- Exclude checks
Doc comment for parameter $filter does not match actual variable name $resource Open
Open
* @param string $filter See: services.yaml parameter "glide_media_filters" to see the list of filters.- Exclude checks
Add a single space around assignment operators Open
Open
declare(strict_types=1);- Exclude checks