src/CoreBundle/Repository/SessionRepository.php
The class SessionRepository has a coupling between objects value of 14. Consider to reduce the number of dependencies under 13. Open
Open
class SessionRepository extends ServiceEntityRepository
{
public function __construct(
ManagerRegistry $registry,
private readonly SettingsManager $settingsManager,- Read upRead up
- Exclude checks
CouplingBetweenObjects
Since: 1.1.0
A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability
Example
class Foo {
/**
* @var \foo\bar\X
*/
private $x = null;
/**
* @var \foo\bar\Y
*/
private $y = null;
/**
* @var \foo\bar\Z
*/
private $z = null;
public function setFoo(\Foo $foo) {}
public function setBar(\Bar $bar) {}
public function setBaz(\Baz $baz) {}
/**
* @return \SplObjectStorage
* @throws \OutOfRangeException
* @throws \InvalidArgumentException
* @throws \ErrorException
*/
public function process(\Iterator $it) {}
// ...
}Source https://phpmd.org/rules/design.html#couplingbetweenobjects
The method getUserFollowedSessionsInAccessUrl uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
Open
} else {
$idList = array_map($callback, $user->getSessionsAsStudent());
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
Missing function doc comment Open
Open
public function __construct(- Exclude checks
Add a single space around assignment operators Open
Open
declare(strict_types=1);- Exclude checks
Missing function doc comment Open
Open
public function create(): ?Session- Exclude checks
Missing function doc comment Open
Open
public function getSessionsByUser(User $user, AccessUrl $url): QueryBuilder- Exclude checks
Missing function doc comment Open
Open
public function update(Session $session): void- Exclude checks
Declare public methods first,then protected ones and finally private ones Open
Open
public function getUserFollowedSessionsInAccessUrl(User $user, AccessUrl $url): QueryBuilder- Exclude checks
Space before opening parenthesis of function call prohibited Open
Open
$callback = fn (Session $session) => $session->getId();- Exclude checks
Missing function doc comment Open
Open
public function countUsersBySession(int $sessionId, int $relationType = Session::STUDENT): int- Exclude checks
Missing function doc comment Open
Open
public function getUserFollowedSessionsInAccessUrl(User $user, AccessUrl $url): QueryBuilder- Exclude checks
Missing function doc comment Open
Open
public function addUserInCourse(int $relationType, User $user, Course $course, Session $session): void- Exclude checks
Arguments with default values must be at the end of the argument list Open
Open
bool $ignoreVisibilityForAdmins = false,- Exclude checks
Line indented incorrectly; expected 4 spaces, found 8 Open
Open
private readonly SettingsManager $settingsManager,- Exclude checks
Space before opening parenthesis of function call prohibited Open
Open
$callback = fn (Session $session) => $session->getId();- Exclude checks