Sign upLogin

changeweb/Unifiedtransform

View on GitHub
Star
app/Http/Controllers/MarkController.php

Summary

Maintainability
C
7 hrs
Test Coverage

Method index has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function index(Request $request)
    {
        $class_id = $request->query('class_id', 0);
        $section_id = $request->query('section_id', 0);
        $course_id = $request->query('course_id', 0);
Severity: Minor
Found in app/Http/Controllers/MarkController.php - About 1 hr to fix

    Method showCourseMark has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function showCourseMark(Request $request)
    {
        $session_id = $request->query('session_id');
        $semester_id = $request->query('semester_id');
        $class_id = $request->query('class_id');
    Severity: Minor
    Found in app/Http/Controllers/MarkController.php - About 1 hr to fix

      Method create has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function create(Request $request)
    {
        $class_id = $request->query('class_id');
        $section_id = $request->query('section_id');
        $course_id = $request->query('course_id');
      Severity: Minor
      Found in app/Http/Controllers/MarkController.php - About 1 hr to fix

        Function showCourseMark has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

            public function showCourseMark(Request $request)
    {
        $session_id = $request->query('session_id');
        $semester_id = $request->query('semester_id');
        $class_id = $request->query('class_id');
        Severity: Minor
        Found in app/Http/Controllers/MarkController.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function index has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

            public function index(Request $request)
    {
        $class_id = $request->query('class_id', 0);
        $section_id = $request->query('section_id', 0);
        $course_id = $request->query('course_id', 0);
        Severity: Minor
        Found in app/Http/Controllers/MarkController.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method __construct has 7 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                AcademicSettingInterface $academicSettingRepository,
        UserInterface $userRepository,
        SchoolSessionInterface $schoolSessionRepository,
        SchoolClassInterface $schoolClassRepository,
        SectionInterface $schoolSectionRepository,
        Severity: Major
        Found in app/Http/Controllers/MarkController.php - About 50 mins to fix

          There are no issues that match your filters.

          Category
          Status