Sign upLogin

changeweb/Unifiedtransform

View on GitHub
Star

Showing 50 of 50 total issues

Method getFinalMarksCount has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public function getFinalMarksCount($session_id, $semester_id, $class_id, $section_id, $course_id) {
Severity: Minor
Found in app/Repositories/MarkRepository.php - About 35 mins to fix

    Method getAllFinalMarks has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public function getAllFinalMarks($session_id, $semester_id, $class_id, $section_id, $course_id) {
    Severity: Minor
    Found in app/Repositories/MarkRepository.php - About 35 mins to fix

      Method getAssignedTeacher has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public function getAssignedTeacher($session_id, $semester_id, $class_id, $section_id, $course_id) {
      Severity: Minor
      Found in app/Repositories/AssignedTeacherRepository.php - About 35 mins to fix

        Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                UserInterface $userRepository,
        AcademicSettingInterface $academicSettingRepository,
        SchoolSessionInterface $schoolSessionRepository,
        SchoolClassInterface $schoolClassRepository,
        SectionInterface $sectionRepository
        Severity: Minor
        Found in app/Http/Controllers/AttendanceController.php - About 35 mins to fix

          Method getAll has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              public function getAll($session_id, $semester_id, $class_id, $section_id, $course_id) {
          Severity: Minor
          Found in app/Repositories/MarkRepository.php - About 35 mins to fix

            Method getAssignedTeacher has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                public function getAssignedTeacher($session_id, $semester_id, $class_id, $section_id, $course_id);
            Severity: Minor
            Found in app/Interfaces/AssignedTeacherInterface.php - About 35 mins to fix

              Method getAll has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  public function getAll($session_id, $semester_id, $class_id, $section_id, $course_id);
              Severity: Minor
              Found in app/Interfaces/MarkInterface.php - About 35 mins to fix

                Function getAllStudents has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function getAllStudents($session_id, $class_id, $section_id) {
        if($class_id == 0 || $section_id == 0) {
            $schoolClass = SchoolClass::where('session_id', $session_id)
                                    ->first();
            $section = Section::where('session_id', $session_id)
                Severity: Minor
                Found in app/Repositories/UserRepository.php - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                <?php

namespace App\Http\Controllers;

use App\Http\Controllers\Controller;
                Severity: Minor
                Found in app/Http/Controllers/StudentParentInfoController.php and 1 other location - About 30 mins to fix
                app/Http/Controllers/StudentAcademicInfoController.php on lines 1..86

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 90.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                <?php

namespace App\Http\Controllers;

use App\Http\Controllers\Controller;
                Severity: Minor
                Found in app/Http/Controllers/StudentAcademicInfoController.php and 1 other location - About 30 mins to fix
                app/Http/Controllers/StudentParentInfoController.php on lines 1..86

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 90.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Severity
                Category
                Status
                Source
                Language