Sign upLogin

chdemko/php-sorted-collections

View on GitHub
Star
src/SortedCollection/TreeNode.php

Summary

Maintainability
F
3 days
Test Coverage

Function remove has a Cognitive Complexity of 35 (exceeds 5 allowed). Consider refactoring.
Open

    public function remove($key, $comparator)
    {
        $cmp = call_user_func($comparator, $key, $this->key);

        if ($cmp < 0) {
Severity: Minor
Found in src/SortedCollection/TreeNode.php - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function find has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

    public function find($key, $comparator, $type = 0)
    {
        $node = $this;

        while (true) {
Severity: Minor
Found in src/SortedCollection/TreeNode.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File TreeNode.php has 299 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/**
 * chdemko\SortedCollection\TreeNode class
 *
Severity: Minor
Found in src/SortedCollection/TreeNode.php - About 3 hrs to fix

    Function insert has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

        public function insert($key, $value, $comparator)
    {
        $node = $this;
        $cmp = call_user_func($comparator, $key, $this->key);
    Severity: Minor
    Found in src/SortedCollection/TreeNode.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method remove has 44 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function remove($key, $comparator)
    {
        $cmp = call_user_func($comparator, $key, $this->key);

        if ($cmp < 0) {
    Severity: Minor
    Found in src/SortedCollection/TreeNode.php - About 1 hr to fix

      Function pullUpLeftMost has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

          private function pullUpLeftMost()
    {
        if ($this->information & 2) {
            $leftBalance = $this->left->information & ~3;
            $this->left = $this->left->pullUpLeftMost();
      Severity: Minor
      Found in src/SortedCollection/TreeNode.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method find has 36 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function find($key, $comparator, $type = 0)
    {
        $node = $this;

        while (true) {
      Severity: Minor
      Found in src/SortedCollection/TreeNode.php - About 1 hr to fix

        Method insert has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function insert($key, $value, $comparator)
    {
        $node = $this;
        $cmp = call_user_func($comparator, $key, $this->key);
        Severity: Minor
        Found in src/SortedCollection/TreeNode.php - About 1 hr to fix

          Avoid too many return statements within this method.
          Open

                          return $this->count();
          Severity: Major
          Found in src/SortedCollection/TreeNode.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                            return null;
            Severity: Major
            Found in src/SortedCollection/TreeNode.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                                      return null;
              Severity: Major
              Found in src/SortedCollection/TreeNode.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                                return $node->successor;
                Severity: Major
                Found in src/SortedCollection/TreeNode.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                                          return $right;
                  Severity: Major
                  Found in src/SortedCollection/TreeNode.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                    return $node->right;
                    Severity: Major
                    Found in src/SortedCollection/TreeNode.php - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                                      return $node->predecessor;
                      Severity: Major
                      Found in src/SortedCollection/TreeNode.php - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                            return $this->left;
                        Severity: Major
                        Found in src/SortedCollection/TreeNode.php - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                  return $this;
                          Severity: Major
                          Found in src/SortedCollection/TreeNode.php - About 30 mins to fix

                            Avoid too many return statements within this method.
                            Open

                                            return $this->key;
                            Severity: Major
                            Found in src/SortedCollection/TreeNode.php - About 30 mins to fix

                              Avoid too many return statements within this method.
                              Open

                                              return $node;
                              Severity: Major
                              Found in src/SortedCollection/TreeNode.php - About 30 mins to fix

                                Avoid too many return statements within this method.
                                Open

                                                        return $left;
                                Severity: Major
                                Found in src/SortedCollection/TreeNode.php - About 30 mins to fix

                                  Similar blocks of code found in 2 locations. Consider refactoring.
                                  Open

                                          } elseif ($cmp > 0) {
            if ($this->information & 1) {
                $rightBalance = $this->right->information & ~3;
                $this->right = $this->right->remove($key, $comparator);
                                  Severity: Minor
                                  Found in src/SortedCollection/TreeNode.php and 1 other location - About 40 mins to fix
                                  src/SortedCollection/TreeNode.php on lines 520..568

                                  Duplicated Code

                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                  Tuning

                                  This issue has a mass of 94.

                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                  Refactorings

                                  Further Reading

                                  Similar blocks of code found in 2 locations. Consider refactoring.
                                  Open

                                          if ($cmp < 0) {
            if ($this->information & 2) {
                $leftBalance = $this->left->information & ~3;
                $this->left = $this->left->remove($key, $comparator);
                                  Severity: Minor
                                  Found in src/SortedCollection/TreeNode.php and 1 other location - About 40 mins to fix
                                  src/SortedCollection/TreeNode.php on lines 529..538

                                  Duplicated Code

                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                  Tuning

                                  This issue has a mass of 94.

                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                  Refactorings

                                  Further Reading

                                  There are no issues that match your filters.

                                  Category
                                  Status