Sign upLogin

checkr/checkr-ruby

View on GitHub
Star

Showing 30 of 30 total issues

Similar blocks of code found in 5 locations. Consider refactoring.
Open

  class FederalCivilSearch < APIResource

    attribute :status
    attribute :result
    attribute :cancellation_reason
Severity: Major
Found in lib/checkr/federal_civil_search.rb and 4 other locations - About 30 mins to fix
lib/checkr/eviction_search.rb on lines 2..18
lib/checkr/federal_criminal_search.rb on lines 2..18
lib/checkr/global_watchlist_search.rb on lines 2..18
lib/checkr/national_criminal_search.rb on lines 2..18

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 32.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

  class GlobalWatchlistSearch < APIResource

    attribute :status
    attribute :result
    attribute :cancellation_reason
Severity: Major
Found in lib/checkr/global_watchlist_search.rb and 4 other locations - About 30 mins to fix
lib/checkr/eviction_search.rb on lines 2..18
lib/checkr/federal_civil_search.rb on lines 2..18
lib/checkr/federal_criminal_search.rb on lines 2..18
lib/checkr/national_criminal_search.rb on lines 2..18

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 32.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

  class FederalCriminalSearch < APIResource

    attribute :status
    attribute :result
    attribute :cancellation_reason
Severity: Major
Found in lib/checkr/federal_criminal_search.rb and 4 other locations - About 30 mins to fix
lib/checkr/eviction_search.rb on lines 2..18
lib/checkr/federal_civil_search.rb on lines 2..18
lib/checkr/global_watchlist_search.rb on lines 2..18
lib/checkr/national_criminal_search.rb on lines 2..18

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 32.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method determine_attr_value has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def self.determine_attr_value(klass, val, opts={}, this=self)
      args = (opts && opts[:nested]) ? [val, this] : [val]
      if klass.is_a?(Proc)
        klass.call(*args)
      elsif klass.is_a?(Class)
Severity: Minor
Found in lib/checkr/api_class.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method refresh_from_hash has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def refresh_from_hash(json={})
      klass = api_list_klass

      json.each do |k, v|
        if self.class.attribute_writer_names.include?(k.to_sym)
Severity: Minor
Found in lib/checkr/api_list.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

  def run_global_watchlist_search_tests(consider, clear)
    puts "Retrieving using consider..."
    consider.global_watchlist_search.refresh
    puts "Retrieved the global_watchlist_search: #{consider.global_watchlist_search.inspect}"
Severity: Minor
Found in tasks/api_test.rb and 4 other locations - About 20 mins to fix
tasks/api_test.rb on lines 118..127
tasks/api_test.rb on lines 130..139
tasks/api_test.rb on lines 154..163
tasks/api_test.rb on lines 178..187

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 28.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

  def run_ssn_trace_tests(consider, clear)
    puts "Retrieving SSN Trace using the consider report."
    consider.ssn_trace.refresh
    puts "Retrieved the SSN Trace: #{consider.ssn_trace.inspect}"
Severity: Minor
Found in tasks/api_test.rb and 4 other locations - About 20 mins to fix
tasks/api_test.rb on lines 130..139
tasks/api_test.rb on lines 142..151
tasks/api_test.rb on lines 154..163
tasks/api_test.rb on lines 178..187

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 28.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

  def run_sex_offender_search_tests(consider, clear)
    puts "Retrieving Sex Offender Search using the consider report."
    consider.sex_offender_search.refresh
    puts "Retrieved the Sex Offender Search: #{consider.sex_offender_search.inspect}"
Severity: Minor
Found in tasks/api_test.rb and 4 other locations - About 20 mins to fix
tasks/api_test.rb on lines 118..127
tasks/api_test.rb on lines 142..151
tasks/api_test.rb on lines 154..163
tasks/api_test.rb on lines 178..187

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 28.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

  def run_national_criminal_search_tests(consider, clear)
    puts "Retrieving using consider..."
    consider.national_criminal_search.refresh
    puts "Retrieved the national_criminal_search: #{consider.national_criminal_search.inspect}"
Severity: Minor
Found in tasks/api_test.rb and 4 other locations - About 20 mins to fix
tasks/api_test.rb on lines 118..127
tasks/api_test.rb on lines 130..139
tasks/api_test.rb on lines 142..151
tasks/api_test.rb on lines 178..187

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 28.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

  def run_motor_vehicle_report_tests(consider, clear)
    puts "Retrieving using consider..."
    consider.motor_vehicle_report.refresh
    puts "Retrieved the motor_vehicle_report: #{consider.motor_vehicle_report.inspect}"
Severity: Minor
Found in tasks/api_test.rb and 4 other locations - About 20 mins to fix
tasks/api_test.rb on lines 118..127
tasks/api_test.rb on lines 130..139
tasks/api_test.rb on lines 142..151
tasks/api_test.rb on lines 154..163

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 28.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language