chef-cookbooks/httpd

View on GitHub

Showing 35 of 35 total issues

File info_module_packages.rb has 329 lines of code (exceeds 250 allowed). Consider refactoring.
Open

module HttpdCookbook
  module Helpers
    module ModuleInfoDSL
      # create big crash hash with other hashes as keys
      # {:platform=>"amazon", :httpd_version=>"2.4", :module=>"rev"}=>"mod_revocator",
Severity: Minor
Found in libraries/info_module_packages.rb - About 3 hrs to fix

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

                  are: %w(
                    access_compat actions alias allowmethods asis auth_basic
                    auth_digest authn_anon authn_core authn_dbd authn_dbm authn_file
                    authn_socache authz_core authz_dbd authz_dbm authz_groupfile
                    authz_host authz_owner authz_user autoindex buffer cache cache_disk
    Severity: Major
    Found in libraries/info_module_packages.rb and 1 other location - About 2 hrs to fix
    libraries/info_module_packages.rb on lines 221..237

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 101.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

                  are: %w(
                    access_compat actions alias allowmethods asis auth_basic
                    auth_digest authn_anon authn_core authn_dbd authn_dbm authn_file
                    authn_socache authz_core authz_dbd authz_dbm authz_groupfile
                    authz_host authz_owner authz_user autoindex buffer cache cache_disk
    Severity: Major
    Found in libraries/info_module_packages.rb and 1 other location - About 2 hrs to fix
    libraries/info_module_packages.rb on lines 160..176

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 101.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method create_setup_service has 50 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def create_setup_service
            httpd_module 'systemd' do
              httpd_version new_resource.version
              instance new_resource.instance
              notifies :reload, "service[#{apache_name}]"
    Severity: Minor
    Found in libraries/httpd_service_rhel_systemd.rb - About 2 hrs to fix

      Method create_setup_service has 39 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            def create_setup_service
              directory "/run/#{apache_name}" do
                owner 'root'
                group 'root'
                mode '0755'
      Severity: Minor
      Found in libraries/httpd_service_debian_systemd.rb - About 1 hr to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

              def delete_stop_service
                service apache_name do
                  supports restart: true, reload: true, status: true
                  provider Chef::Provider::Service::Init::Systemd
                  action [:stop, :disable]
        Severity: Major
        Found in libraries/httpd_service_rhel_systemd.rb and 1 other location - About 1 hr to fix
        libraries/httpd_service_debian_systemd.rb on lines 94..113

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 60.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

              def delete_stop_service
                service apache_name do
                  supports restart: true, reload: true, status: true
                  provider Chef::Provider::Service::Init::Systemd
                  action [:stop, :disable]
        Severity: Major
        Found in libraries/httpd_service_debian_systemd.rb and 1 other location - About 1 hr to fix
        libraries/httpd_service_rhel_systemd.rb on lines 107..126

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 60.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Method default_apache_version has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

            def default_apache_version
              return '2.2' if node['platform_family'] == 'debian' && node['platform_version'].to_i == 7
              return '2.2' if node['platform_family'] == 'rhel' && node['platform_version'].to_i == 6
              return '2.4' if node['platform_family'] == 'debian' && node['platform_version'].to_i >= 8
              return '2.4' if node['platform_family'] == 'fedora'
        Severity: Minor
        Found in libraries/helpers.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method default_filename has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

            def default_filename
              case node['platform_family']
              when 'debian'
                return 'libphp5.so' if module_name == 'php5'
              when 'rhel'
        Severity: Minor
        Found in libraries/httpd_module.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

              httpd_config "mpm_#{new_resource.mpm}" do
                instance new_resource.instance
                source 'mpm.conf.erb'
                variables(
                  maxclients: new_resource.maxclients,
        Severity: Major
        Found in libraries/httpd_service_debian.rb and 1 other location - About 1 hr to fix
        libraries/httpd_service_rhel.rb on lines 66..85

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 54.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

              httpd_config "mpm_#{new_resource.mpm}" do
                instance new_resource.instance
                source 'mpm.conf.erb'
                variables(
                  maxclients: new_resource.maxclients,
        Severity: Major
        Found in libraries/httpd_service_rhel.rb and 1 other location - About 1 hr to fix
        libraries/httpd_service_debian.rb on lines 213..232

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 54.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Method create_setup_service has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

              def create_setup_service
                template "/etc/init.d/#{apache_name}" do
                  source "#{new_resource.version}/sysvinit/el-#{elversion}/httpd.erb"
                  owner 'root'
                  group 'root'
        Severity: Minor
        Found in libraries/httpd_service_rhel_sysvinit.rb - About 1 hr to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  directory "/etc/#{apache_name}/conf.d" do
                    owner 'root'
                    group 'root'
                    mode '0755'
                    recursive true
          Severity: Major
          Found in libraries/httpd_config_debian.rb and 1 other location - About 1 hr to fix
          libraries/httpd_config_rhel.rb on lines 7..24

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 52.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                directory "/etc/#{apache_name}/conf.d" do
                  owner 'root'
                  group 'root'
                  mode '0755'
                  recursive true
          Severity: Major
          Found in libraries/httpd_config_rhel.rb and 1 other location - About 1 hr to fix
          libraries/httpd_config_debian.rb on lines 8..25

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 52.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  directory "/etc/#{apache_name}/conf.d" do
                    owner 'root'
                    group 'root'
                    recursive true
                    action :create
          Severity: Minor
          Found in libraries/httpd_module_rhel.rb and 1 other location - About 55 mins to fix
          libraries/httpd_module_rhel.rb on lines 33..51

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 46.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  directory "/etc/#{apache_name}/conf.modules.d" do
                    owner 'root'
                    group 'root'
                    recursive true
                    action :create
          Severity: Minor
          Found in libraries/httpd_module_rhel.rb and 1 other location - About 55 mins to fix
          libraries/httpd_module_rhel.rb on lines 13..31

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 46.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Method package_name_for_module has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              def package_name_for_module(name, httpd_version, platform, platform_family, platform_version)
          Severity: Minor
          Found in libraries/info_module_packages.rb - About 35 mins to fix

            Avoid too many return statements within this method.
            Open

                  return '2.4' if node['platform_family'] == 'rhel' && node['platform_version'].to_i >= 7
            Severity: Major
            Found in libraries/helpers.rb - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                    return '2.4' if node['platform'] == 'ubuntu'
              Severity: Major
              Found in libraries/helpers.rb - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                      return '2.4' if node['platform'] == 'amazon'
                Severity: Major
                Found in libraries/helpers.rb - About 30 mins to fix
                  Severity
                  Category
                  Status
                  Source
                  Language