Sign upLogin

chiiya/shion

View on GitHub
Star

Showing 216 of 216 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    try {
      results = await this.optimizeImages(input, output, options)
    } catch (error: any) {
      this.logger.error(`${error.message}\n${error.stack}`)
    }
Severity: Major
Found in src/shion.ts and 1 other location - About 1 hr to fix
src/shion.ts on lines 63..67

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 72.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    try {
      result = await this.resizeImages(input, output, options)
    } catch (error: any) {
      this.logger.error(`${error.message}\n${error.stack}`)
    }
Severity: Major
Found in src/shion.ts and 1 other location - About 1 hr to fix
src/shion.ts on lines 45..49

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 72.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function optimizeImage has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  public async optimizeImage(
    input: Input,
    output: Output,
    options: OptimizeOptions
  ): Promise<OptimizeResult[]> {
Severity: Minor
Found in src/processor.ts - About 1 hr to fix

    Function getResizeConfiguration has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      protected getResizeConfiguration(options?: ResizeOptions): ResolvedResizeOptions {
    let defaults = {
      jpg: {
        force: false,
      },
    Severity: Minor
    Found in src/shion.ts - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        succeed(message: string) {
    if (this.spinner.isSpinning) {
      this.spinner.succeed(message)
    }
  }
      Severity: Minor
      Found in src/logger.ts and 1 other location - About 35 mins to fix
      src/logger.ts on lines 83..87

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 47.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        fail(message: string) {
    if (this.spinner.isSpinning) {
      this.spinner.fail(message)
    }
  }
      Severity: Minor
      Found in src/logger.ts and 1 other location - About 35 mins to fix
      src/logger.ts on lines 73..77

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 47.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

      export const getStringInputAsArray = (data: string | string[]): string[] => {
  if (Array.isArray(data)) {
    data = [...data]
  } else {
    data = [data]
      Severity: Minor
      Found in src/helpers.ts and 1 other location - About 35 mins to fix
      src/helpers.ts on lines 106..113

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 46.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

      export const getNumberInputAsArray = (data: number | number[]): number[] => {
  if (Array.isArray(data)) {
    data = [...data]
  } else {
    data = [data]
      Severity: Minor
      Found in src/helpers.ts and 1 other location - About 35 mins to fix
      src/helpers.ts on lines 93..100

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 46.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Missing semicolon
      Open

        return parseFloat((bytes / Math.pow(1024, i)).toFixed(2)) + ' ' + sizes[i]
      Severity: Minor
      Found in src/helpers.ts by tslint

      Rule: semicolon

      Enforces consistent semicolon usage at the end of every statement.

      Notes
      • Has Fix

      Config

      One of the following arguments must be provided:

      • "always" enforces semicolons at the end of every statement.
      • "never" disallows semicolons at the end of every statement except for when they are necessary.

      The following arguments may be optionally provided:

      • "ignore-interfaces" skips checking semicolons at the end of interface members.
      • "ignore-bound-class-methods" skips checking semicolons at the end of bound class methods.
      • "strict-bound-class-methods" disables any special handling of bound class methods and treats them as any other assignment. This option overrides "ignore-bound-class-methods".
      Examples
      "semicolon": true,always
      "semicolon": true,never
      "semicolon": true,always,ignore-interfaces
      "semicolon": true,always,ignore-bound-class-methods
      Schema
      {
  "type": "array",
  "items": [
    {
      "type": "string",
      "enum": [
        "always",
        "never"
      ]
    },
    {
      "type": "string",
      "enum": [
        "ignore-interfaces"
      ]
    }
  ],
  "additionalItems": false
}

      For more information see this page.

      Missing semicolon
      Open

      }
      Severity: Minor
      Found in src/helpers.ts by tslint

      Rule: semicolon

      Enforces consistent semicolon usage at the end of every statement.

      Notes
      • Has Fix

      Config

      One of the following arguments must be provided:

      • "always" enforces semicolons at the end of every statement.
      • "never" disallows semicolons at the end of every statement except for when they are necessary.

      The following arguments may be optionally provided:

      • "ignore-interfaces" skips checking semicolons at the end of interface members.
      • "ignore-bound-class-methods" skips checking semicolons at the end of bound class methods.
      • "strict-bound-class-methods" disables any special handling of bound class methods and treats them as any other assignment. This option overrides "ignore-bound-class-methods".
      Examples
      "semicolon": true,always
      "semicolon": true,never
      "semicolon": true,always,ignore-interfaces
      "semicolon": true,always,ignore-bound-class-methods
      Schema
      {
  "type": "array",
  "items": [
    {
      "type": "string",
      "enum": [
        "always",
        "never"
      ]
    },
    {
      "type": "string",
      "enum": [
        "ignore-interfaces"
      ]
    }
  ],
  "additionalItems": false
}

      For more information see this page.

      Missing semicolon
      Open

          this.spinner.stop()
      Severity: Minor
      Found in src/logger.ts by tslint

      Rule: semicolon

      Enforces consistent semicolon usage at the end of every statement.

      Notes
      • Has Fix

      Config

      One of the following arguments must be provided:

      • "always" enforces semicolons at the end of every statement.
      • "never" disallows semicolons at the end of every statement except for when they are necessary.

      The following arguments may be optionally provided:

      • "ignore-interfaces" skips checking semicolons at the end of interface members.
      • "ignore-bound-class-methods" skips checking semicolons at the end of bound class methods.
      • "strict-bound-class-methods" disables any special handling of bound class methods and treats them as any other assignment. This option overrides "ignore-bound-class-methods".
      Examples
      "semicolon": true,always
      "semicolon": true,never
      "semicolon": true,always,ignore-interfaces
      "semicolon": true,always,ignore-bound-class-methods
      Schema
      {
  "type": "array",
  "items": [
    {
      "type": "string",
      "enum": [
        "always",
        "never"
      ]
    },
    {
      "type": "string",
      "enum": [
        "ignore-interfaces"
      ]
    }
  ],
  "additionalItems": false
}

      For more information see this page.

      Missing semicolon
      Open

          const newSize = optimizedBuffer.length
      Severity: Minor
      Found in src/processor.ts by tslint

      Rule: semicolon

      Enforces consistent semicolon usage at the end of every statement.

      Notes
      • Has Fix

      Config

      One of the following arguments must be provided:

      • "always" enforces semicolons at the end of every statement.
      • "never" disallows semicolons at the end of every statement except for when they are necessary.

      The following arguments may be optionally provided:

      • "ignore-interfaces" skips checking semicolons at the end of interface members.
      • "ignore-bound-class-methods" skips checking semicolons at the end of bound class methods.
      • "strict-bound-class-methods" disables any special handling of bound class methods and treats them as any other assignment. This option overrides "ignore-bound-class-methods".
      Examples
      "semicolon": true,always
      "semicolon": true,never
      "semicolon": true,always,ignore-interfaces
      "semicolon": true,always,ignore-bound-class-methods
      Schema
      {
  "type": "array",
  "items": [
    {
      "type": "string",
      "enum": [
        "always",
        "never"
      ]
    },
    {
      "type": "string",
      "enum": [
        "ignore-interfaces"
      ]
    }
  ],
  "additionalItems": false
}

      For more information see this page.

      Missing semicolon
      Open

          await copyFile(input.fullPath, output.fullPath)
      Severity: Minor
      Found in src/processor.ts by tslint

      Rule: semicolon

      Enforces consistent semicolon usage at the end of every statement.

      Notes
      • Has Fix

      Config

      One of the following arguments must be provided:

      • "always" enforces semicolons at the end of every statement.
      • "never" disallows semicolons at the end of every statement except for when they are necessary.

      The following arguments may be optionally provided:

      • "ignore-interfaces" skips checking semicolons at the end of interface members.
      • "ignore-bound-class-methods" skips checking semicolons at the end of bound class methods.
      • "strict-bound-class-methods" disables any special handling of bound class methods and treats them as any other assignment. This option overrides "ignore-bound-class-methods".
      Examples
      "semicolon": true,always
      "semicolon": true,never
      "semicolon": true,always,ignore-interfaces
      "semicolon": true,always,ignore-bound-class-methods
      Schema
      {
  "type": "array",
  "items": [
    {
      "type": "string",
      "enum": [
        "always",
        "never"
      ]
    },
    {
      "type": "string",
      "enum": [
        "ignore-interfaces"
      ]
    }
  ],
  "additionalItems": false
}

      For more information see this page.

      Use a conditional expression instead of assigning to 'result' in multiple places.
      Open

              if (configuration.optimize === true) {
      Severity: Minor
      Found in src/shion.ts by tslint

      Rule: prefer-conditional-expression

      Recommends to use a conditional expression instead of assigning to the same thing in each branch of an if statement.

      Rationale

      This reduces duplication and can eliminate an unnecessary variable declaration.

      Config

      If check-else-if is specified, the rule also checks nested if-else-if statements.

      Examples
      "prefer-conditional-expression": true
      "prefer-conditional-expression": true,check-else-if
      Schema
      {
  "type": "string",
  "enum": [
    "check-else-if"
  ]
}

      For more information see this page.

      Missing semicolon
      Open

      import Processor from './processor'
      Severity: Minor
      Found in src/shion.ts by tslint

      Rule: semicolon

      Enforces consistent semicolon usage at the end of every statement.

      Notes
      • Has Fix

      Config

      One of the following arguments must be provided:

      • "always" enforces semicolons at the end of every statement.
      • "never" disallows semicolons at the end of every statement except for when they are necessary.

      The following arguments may be optionally provided:

      • "ignore-interfaces" skips checking semicolons at the end of interface members.
      • "ignore-bound-class-methods" skips checking semicolons at the end of bound class methods.
      • "strict-bound-class-methods" disables any special handling of bound class methods and treats them as any other assignment. This option overrides "ignore-bound-class-methods".
      Examples
      "semicolon": true,always
      "semicolon": true,never
      "semicolon": true,always,ignore-interfaces
      "semicolon": true,always,ignore-bound-class-methods
      Schema
      {
  "type": "array",
  "items": [
    {
      "type": "string",
      "enum": [
        "always",
        "never"
      ]
    },
    {
      "type": "string",
      "enum": [
        "ignore-interfaces"
      ]
    }
  ],
  "additionalItems": false
}

      For more information see this page.

      Missing semicolon
      Open

          this.printWarnings(result.warnings)
      Severity: Minor
      Found in src/shion.ts by tslint

      Rule: semicolon

      Enforces consistent semicolon usage at the end of every statement.

      Notes
      • Has Fix

      Config

      One of the following arguments must be provided:

      • "always" enforces semicolons at the end of every statement.
      • "never" disallows semicolons at the end of every statement except for when they are necessary.

      The following arguments may be optionally provided:

      • "ignore-interfaces" skips checking semicolons at the end of interface members.
      • "ignore-bound-class-methods" skips checking semicolons at the end of bound class methods.
      • "strict-bound-class-methods" disables any special handling of bound class methods and treats them as any other assignment. This option overrides "ignore-bound-class-methods".
      Examples
      "semicolon": true,always
      "semicolon": true,never
      "semicolon": true,always,ignore-interfaces
      "semicolon": true,always,ignore-bound-class-methods
      Schema
      {
  "type": "array",
  "items": [
    {
      "type": "string",
      "enum": [
        "always",
        "never"
      ]
    },
    {
      "type": "string",
      "enum": [
        "ignore-interfaces"
      ]
    }
  ],
  "additionalItems": false
}

      For more information see this page.

      Missing semicolon
      Open

          })
      Severity: Minor
      Found in src/shion.ts by tslint

      Rule: semicolon

      Enforces consistent semicolon usage at the end of every statement.

      Notes
      • Has Fix

      Config

      One of the following arguments must be provided:

      • "always" enforces semicolons at the end of every statement.
      • "never" disallows semicolons at the end of every statement except for when they are necessary.

      The following arguments may be optionally provided:

      • "ignore-interfaces" skips checking semicolons at the end of interface members.
      • "ignore-bound-class-methods" skips checking semicolons at the end of bound class methods.
      • "strict-bound-class-methods" disables any special handling of bound class methods and treats them as any other assignment. This option overrides "ignore-bound-class-methods".
      Examples
      "semicolon": true,always
      "semicolon": true,never
      "semicolon": true,always,ignore-interfaces
      "semicolon": true,always,ignore-bound-class-methods
      Schema
      {
  "type": "array",
  "items": [
    {
      "type": "string",
      "enum": [
        "always",
        "never"
      ]
    },
    {
      "type": "string",
      "enum": [
        "ignore-interfaces"
      ]
    }
  ],
  "additionalItems": false
}

      For more information see this page.

      Missing semicolon
      Open

            )
      Severity: Minor
      Found in src/shion.ts by tslint

      Rule: semicolon

      Enforces consistent semicolon usage at the end of every statement.

      Notes
      • Has Fix

      Config

      One of the following arguments must be provided:

      • "always" enforces semicolons at the end of every statement.
      • "never" disallows semicolons at the end of every statement except for when they are necessary.

      The following arguments may be optionally provided:

      • "ignore-interfaces" skips checking semicolons at the end of interface members.
      • "ignore-bound-class-methods" skips checking semicolons at the end of bound class methods.
      • "strict-bound-class-methods" disables any special handling of bound class methods and treats them as any other assignment. This option overrides "ignore-bound-class-methods".
      Examples
      "semicolon": true,always
      "semicolon": true,never
      "semicolon": true,always,ignore-interfaces
      "semicolon": true,always,ignore-bound-class-methods
      Schema
      {
  "type": "array",
  "items": [
    {
      "type": "string",
      "enum": [
        "always",
        "never"
      ]
    },
    {
      "type": "string",
      "enum": [
        "ignore-interfaces"
      ]
    }
  ],
  "additionalItems": false
}

      For more information see this page.

      unused expression, expected an assignment or function call
      Open

      import type { FileInformation } from '../types/types.js'
      Severity: Minor
      Found in src/helpers.ts by tslint

      Rule: no-unused-expression

      Disallows unused expression statements.

      Unused expressions are expression statements which are not assignments or function calls (and thus usually no-ops).

      Rationale

      Detects potential errors where an assignment or function call was intended.

      Config

      Three arguments may be optionally provided:

      • allow-fast-null-checks allows to use logical operators to perform fast null checks and perform method or function calls for side effects (e.g. e && e.preventDefault()).
      • allow-new allows 'new' expressions for side effects (e.g. new ModifyGlobalState();.
      • allow-tagged-template allows tagged templates for side effects (e.g. this.add\foo`;`.
      Examples
      "no-unused-expression": true
      "no-unused-expression": true,allow-fast-null-checks
      Schema
      {
  "type": "array",
  "items": {
    "type": "string",
    "enum": [
      "allow-fast-null-checks",
      "allow-new",
      "allow-tagged-template"
    ]
  },
  "minLength": 0,
  "maxLength": 3
}

      For more information see this page.

      Missing semicolon
      Open

        const extension = extname(source).substring(1).toUpperCase()
      Severity: Minor
      Found in src/helpers.ts by tslint

      Rule: semicolon

      Enforces consistent semicolon usage at the end of every statement.

      Notes
      • Has Fix

      Config

      One of the following arguments must be provided:

      • "always" enforces semicolons at the end of every statement.
      • "never" disallows semicolons at the end of every statement except for when they are necessary.

      The following arguments may be optionally provided:

      • "ignore-interfaces" skips checking semicolons at the end of interface members.
      • "ignore-bound-class-methods" skips checking semicolons at the end of bound class methods.
      • "strict-bound-class-methods" disables any special handling of bound class methods and treats them as any other assignment. This option overrides "ignore-bound-class-methods".
      Examples
      "semicolon": true,always
      "semicolon": true,never
      "semicolon": true,always,ignore-interfaces
      "semicolon": true,always,ignore-bound-class-methods
      Schema
      {
  "type": "array",
  "items": [
    {
      "type": "string",
      "enum": [
        "always",
        "never"
      ]
    },
    {
      "type": "string",
      "enum": [
        "ignore-interfaces"
      ]
    }
  ],
  "additionalItems": false
}

      For more information see this page.

      Severity
      Category
      Status
      Source
      Language