Sign upLogin

chingor13/json_api_client

View on GitHub
Star
lib/json_api_client/query/builder.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Class Builder has 32 methods (exceeds 20 allowed). Consider refactoring.
Open

    class Builder

      attr_reader :klass
      delegate :key_formatter, to: :klass
Severity: Minor
Found in lib/json_api_client/query/builder.rb - About 4 hrs to fix

    Method parse_orders has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

          def parse_orders(*args)
        args.map do |arg|
          case arg
          when Hash
            arg.map do |k, v|
    Severity: Minor
    Found in lib/json_api_client/query/builder.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method select_params has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

          def select_params
        if @fields.empty?
          {}
        else
          field_result = Hash.new { |h,k| h[k] = [] }
    Severity: Minor
    Found in lib/json_api_client/query/builder.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status