Sign upLogin

chippyash/Math-Matrix

View on GitHub
Star
src/Chippyash/Math/Matrix/Formatter/DirectedGraph.php

Summary

Maintainability
A
2 hrs
Test Coverage

Method format has 51 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function format(Matrix $mA, array $options = array())
    {
        if (!$mA instanceof NumericMatrix) {
            throw new \InvalidArgumentException('Matrix is not NumericMatrix');
        }
Severity: Major
Found in src/Chippyash/Math/Matrix/Formatter/DirectedGraph.php - About 2 hrs to fix

    The method format() has a Cyclomatic Complexity of 14. The configured cyclomatic complexity threshold is 10.
    Open

        public function format(Matrix $mA, array $options = array())
    {
        if (!$mA instanceof NumericMatrix) {
            throw new \InvalidArgumentException('Matrix is not NumericMatrix');
        }
    Severity: Minor
    Found in src/Chippyash/Math/Matrix/Formatter/DirectedGraph.php by phpmd

    CyclomaticComplexity

    Since: 0.1

    Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

    Example

    // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

    Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

    Missing class import via use statement (line '45', column '23').
    Open

                throw new \InvalidArgumentException('Matrix is not NumericMatrix');
    Severity: Minor
    Found in src/Chippyash/Math/Matrix/Formatter/DirectedGraph.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '60', column '27').
    Open

                    throw new \InvalidArgumentException('pptions[edgeFunc]');
    Severity: Minor
    Found in src/Chippyash/Math/Matrix/Formatter/DirectedGraph.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '53', column '27').
    Open

                    throw new \InvalidArgumentException('options[attribs]');
    Severity: Minor
    Found in src/Chippyash/Math/Matrix/Formatter/DirectedGraph.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    The method format uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

                        } else {
                        $vertices[$idx+1] = $graph->createVertex();
                    }
    Severity: Minor
    Found in src/Chippyash/Math/Matrix/Formatter/DirectedGraph.php by phpmd

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    There are no issues that match your filters.

    Category
    Status