Sign upLogin

chippyash/Math-Matrix

View on GitHub
Star
src/Chippyash/Math/Matrix/NumericMatrix.php

Summary

Maintainability
B
5 hrs
Test Coverage

Function checkEntryEquality has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

    protected function checkEntryEquality(Matrix $mB, $strict)
    {
        if ($strict) {
            if (get_class($this) !== get_class($mB)) {
                return false;
Severity: Minor
Found in src/Chippyash/Math/Matrix/NumericMatrix.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method __invoke has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function __invoke()
    {
        //argument arbitrage
        $numArgs = func_num_args();
        if ($numArgs == 1) {
Severity: Minor
Found in src/Chippyash/Math/Matrix/NumericMatrix.php - About 1 hr to fix

    Function __invoke has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        public function __invoke()
    {
        //argument arbitrage
        $numArgs = func_num_args();
        if ($numArgs == 1) {
    Severity: Minor
    Found in src/Chippyash/Math/Matrix/NumericMatrix.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function __construct has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        public function __construct($source, $normalizeDefault = 0)
    {
        if ($source instanceof self) {
            $this->store($source->toArray());
            return;
    Severity: Minor
    Found in src/Chippyash/Math/Matrix/NumericMatrix.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

                return $this->transform(new $tName(), $extra);
    Severity: Major
    Found in src/Chippyash/Math/Matrix/NumericMatrix.php - About 30 mins to fix

      The class NumericMatrix has a coupling between objects value of 13. Consider to reduce the number of dependencies under 13.
      Open

      class NumericMatrix extends Matrix
{
    use ConvertNumberToNumeric;

    const NS_NUMERIC_ATTRIBUTE = 'Chippyash\Math\Matrix\Attribute\Is';
      Severity: Minor
      Found in src/Chippyash/Math/Matrix/NumericMatrix.php by phpmd

      CouplingBetweenObjects

      Since: 1.1.0

      A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

      Example

      class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

      Source https://phpmd.org/rules/design.html#couplingbetweenobjects

      Missing class import via use statement (line '190', column '23').
      Open

                  throw new \InvalidArgumentException(self::ERR_INVALID_INVOKE_ARG);
      Severity: Minor
      Found in src/Chippyash/Math/Matrix/NumericMatrix.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '221', column '19').
      Open

              throw new \InvalidArgumentException(self::ERR_INVALID_OP_NAME);
      Severity: Minor
      Found in src/Chippyash/Math/Matrix/NumericMatrix.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      The method __construct uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
      Open

                  } else {
                $default = $normalizeDefault;
            }
      Severity: Minor
      Found in src/Chippyash/Math/Matrix/NumericMatrix.php by phpmd

      ElseExpression

      Since: 1.4.0

      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

      Example

      class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

      Source https://phpmd.org/rules/cleancode.html#elseexpression

      The method checkEntryEquality uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
      Open

                      } else {
                    if ($comp->neq($dA[$i][$j], $dB[$i][$j])) {
                        return false;
                    }
                }
      Severity: Minor
      Found in src/Chippyash/Math/Matrix/NumericMatrix.php by phpmd

      ElseExpression

      Since: 1.4.0

      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

      Example

      class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

      Source https://phpmd.org/rules/cleancode.html#elseexpression

      The method test uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
      Open

              } else {
            $obj = $attribute;
        }
      Severity: Minor
      Found in src/Chippyash/Math/Matrix/NumericMatrix.php by phpmd

      ElseExpression

      Since: 1.4.0

      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

      Example

      class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

      Source https://phpmd.org/rules/cleancode.html#elseexpression

      The method test uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
      Open

                  } else {
                //let parent try to find the class
                return parent::test($attribute);
            }
      Severity: Minor
      Found in src/Chippyash/Math/Matrix/NumericMatrix.php by phpmd

      ElseExpression

      Since: 1.4.0

      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

      Example

      class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

      Source https://phpmd.org/rules/cleancode.html#elseexpression

      The method __construct uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
      Open

              } else {
            throw new MathMatrixException('NumericMatrix expects NumericMatrix or array as source data');
        }
      Severity: Minor
      Found in src/Chippyash/Math/Matrix/NumericMatrix.php by phpmd

      ElseExpression

      Since: 1.4.0

      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

      Example

      class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

      Source https://phpmd.org/rules/cleancode.html#elseexpression

      The method __invoke uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
      Open

              } else {
            throw new \InvalidArgumentException(self::ERR_INVALID_INVOKE_ARG);
        }
      Severity: Minor
      Found in src/Chippyash/Math/Matrix/NumericMatrix.php by phpmd

      ElseExpression

      Since: 1.4.0

      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

      Example

      class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

      Source https://phpmd.org/rules/cleancode.html#elseexpression

      There are no issues that match your filters.

      Category
      Status