Sign upLogin

chippyash/Math-Type-Calculator

View on GitHub
Star
src/Chippyash/Math/Type/Calculator.php

Summary

Maintainability
D
2 days
Test Coverage

Avoid too many return statements within this method.
Open

                return $this->calcEngine->rationalAdd($a, $b);
Severity: Major
Found in src/Chippyash/Math/Type/Calculator.php - About 30 mins to fix

    Avoid too many return statements within this method.
    Wontfix

                    return $this->calcEngine->floatDiv($a, $b);
    Severity: Major
    Found in src/Chippyash/Math/Type/Calculator.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Wontfix

                      return $this->calcEngine->complexAdd($a, $b->asComplex());
      Severity: Major
      Found in src/Chippyash/Math/Type/Calculator.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Wontfix

                        return $this->calcEngine->complexSub($a, $b->asComplex());
        Severity: Major
        Found in src/Chippyash/Math/Type/Calculator.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Wontfix

                          return $this->calcEngine->rationalSub($a, $b);
          Severity: Major
          Found in src/Chippyash/Math/Type/Calculator.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                            return $this->calcEngine->complexMul($a, $b);
            Severity: Major
            Found in src/Chippyash/Math/Type/Calculator.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                              return $this->calcEngine->rationalMul($a, $b);
              Severity: Major
              Found in src/Chippyash/Math/Type/Calculator.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Wontfix

                                return $this->calcEngine->complexSub($a->asComplex(), $b);
                Severity: Major
                Found in src/Chippyash/Math/Type/Calculator.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                                  return $this->calcEngine->complexDiv($a->asComplex(), $b);
                  Severity: Major
                  Found in src/Chippyash/Math/Type/Calculator.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                    return $this->calcEngine->complexAdd($a->asComplex(), $b);
                    Severity: Major
                    Found in src/Chippyash/Math/Type/Calculator.php - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                                      return $this->calcEngine->complexMul($a->asComplex(), $b);
                      Severity: Major
                      Found in src/Chippyash/Math/Type/Calculator.php - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                        return $this->calcEngine->complexAdd($a, $b);
                        Severity: Major
                        Found in src/Chippyash/Math/Type/Calculator.php - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Wontfix

                                          return $this->calcEngine->complexMul($a, $b->asComplex());
                          Severity: Major
                          Found in src/Chippyash/Math/Type/Calculator.php - About 30 mins to fix

                            Avoid too many return statements within this method.
                            Open

                                            return $this->calcEngine->complexSub($a, $b);
                            Severity: Major
                            Found in src/Chippyash/Math/Type/Calculator.php - About 30 mins to fix

                              Missing class import via use statement (line '69', column '23').
                              Open

                                          throw new \InvalidArgumentException('No known calculator engine');
                              Severity: Minor
                              Found in src/Chippyash/Math/Type/Calculator.php by phpmd

                              MissingImport

                              Since: 2.7.0

                              Importing all external classes in a file through use statements makes them clearly visible.

                              Example

                              function make() {
    return new \stdClass();
}

                              Source http://phpmd.org/rules/cleancode.html#MissingImport

                              Missing class import via use statement (line '287', column '19').
                              Open

                                      throw new \BadMethodCallException('No solution for unknown type: ' . $type);
                              Severity: Minor
                              Found in src/Chippyash/Math/Type/Calculator.php by phpmd

                              MissingImport

                              Since: 2.7.0

                              Importing all external classes in a file through use statements makes them clearly visible.

                              Example

                              function make() {
    return new \stdClass();
}

                              Source http://phpmd.org/rules/cleancode.html#MissingImport

                              Similar blocks of code found in 3 locations. Consider refactoring.
                              Open

                                  public function add($a, $b)
    {
        $a = $this->convert($a);
        $b = $this->convert($b);
                              Severity: Major
                              Found in src/Chippyash/Math/Type/Calculator.php and 2 other locations - About 5 hrs to fix
                              src/Chippyash/Math/Type/Calculator.php on lines 118..140
                              src/Chippyash/Math/Type/Calculator.php on lines 152..174

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 201.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Similar blocks of code found in 3 locations. Consider refactoring.
                              Open

                                  public function mul($a, $b)
    {
        $a = $this->convert($a);
        $b = $this->convert($b);
        switch ($this->arbitrate($a, $b)) {
                              Severity: Major
                              Found in src/Chippyash/Math/Type/Calculator.php and 2 other locations - About 5 hrs to fix
                              src/Chippyash/Math/Type/Calculator.php on lines 83..106
                              src/Chippyash/Math/Type/Calculator.php on lines 118..140

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 201.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Similar blocks of code found in 3 locations. Consider refactoring.
                              Open

                                  public function sub($a, $b)
    {
        $a = $this->convert($a);
        $b = $this->convert($b);
        switch ($this->arbitrate($a, $b)) {
                              Severity: Major
                              Found in src/Chippyash/Math/Type/Calculator.php and 2 other locations - About 5 hrs to fix
                              src/Chippyash/Math/Type/Calculator.php on lines 83..106
                              src/Chippyash/Math/Type/Calculator.php on lines 152..174

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 201.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Similar blocks of code found in 2 locations. Consider refactoring.
                              Open

                                      if (is_null($calcEngine)) {
            $this->calcEngine = new Native();
        } elseif (is_int($calcEngine) && array_key_exists($calcEngine, $this->supportedEngines)) {
            $className = self::NS . $this->supportedEngines[$calcEngine];
            $this->calcEngine = new $className();
                              Severity: Major
                              Found in src/Chippyash/Math/Type/Calculator.php and 1 other location - About 1 hr to fix
                              src/Chippyash/Math/Type/Comparator.php on lines 51..58

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 102.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              There are no issues that match your filters.

                              Category
                              Status