Showing 11 of 13 total issues
Function addRules has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring. Open
protected function addRules(\DOMNodeList $rules)
{
foreach ($rules as $rule) {
//type is a required attribute
$type = $this->getOpType($rule->getAttribute('type'));- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function loadDefinition has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
protected function loadDefinition($xmlFile, $xsdFile)
{
$isString = false;
if (strstr($xmlFile, '<?xml') !== false) {
$isString = true;- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
The closing brace for the interface must go on the next line after the body Open
}- Exclude checks
Function processImports has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
protected function processImports($basePath)
{
$xpath = new \DOMXPath($this->xml);
$xpath->registerNamespace('acl', self::NS);
$importNodes = $xpath->query('//acl:acl/acl:imports/acl:import');- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Missing class import via use statement (line '62', column '22'). Open
$xpath = new \DOMXPath($this->xml);- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '42', column '20'). Open
$xsl = new \XSLTProcessor();- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '43', column '20'). Open
$dom = new \DOMDocument();- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '107', column '23'). Open
$defDom = new \DOMDocument();- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}Source http://phpmd.org/rules/cleancode.html#MissingImport
Function addResources has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
protected function addResources(\DOMNodeList $resources)
{
foreach ($resources as $resource) {
$parent = null;
$resourceType = 'GenericResource';- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Expected 1 newline at end of file; 0 found Open
}- Exclude checks
Expected 1 newline at end of file; 0 found Open
}- Exclude checks