Sign upLogin

chrisjensen/attr_redactor

View on GitHub
Star

Showing 4 of 4 total issues

Method attr_redactor has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

  def attr_redactor(*attributes)
    options = attributes.last.is_a?(Hash) ? attributes.pop : {}
    options = attr_redactor_default_options.dup.merge!(attr_redactor_options).merge!(options)

    attributes.each do |attribute|
Severity: Minor
Found in lib/attr_redactor.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method attr_redactor has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def attr_redactor(*attributes)
    options = attributes.last.is_a?(Hash) ? attributes.pop : {}
    options = attr_redactor_default_options.dup.merge!(attr_redactor_options).merge!(options)

    attributes.each do |attribute|
Severity: Minor
Found in lib/attr_redactor.rb - About 1 hr to fix

    Method extended has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            def self.extended(base) # :nodoc:
          base.class_eval do

            # https://github.com/attr-encrypted/attr_encrypted/issues/68
            alias_method :reload_without_attr_redactor, :reload
    Severity: Minor
    Found in lib/attr_redactor/adapters/active_record.rb - About 1 hr to fix

      Method attribute_instance_methods_as_symbols has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

                def attribute_instance_methods_as_symbols
            # We add accessor methods of the db columns to the list of instance
            # methods returned to let ActiveRecord define the accessor methods
            # for the db columns
      Severity: Minor
      Found in lib/attr_redactor/adapters/active_record.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language