Sign upLogin

chrisjones-tripletri/rake_command_filter

View on GitHub
Star
lib/command_definition.rb

Summary

Maintainability
A
35 mins
Test Coverage

Method output_results has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def output_results(results, saved_lines, command_start)
      results << create_default_result if results.empty?
      worst_results = CommandDefinition.find_worst_result(results)

      # if the lines
Severity: Minor
Found in lib/command_definition.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Use a guard clause instead of wrapping the code inside a conditional expression.
Open

      unless @default_line_handling == RakeCommandFilter::LINE_HANDLING_HIDE_ALWAYS
Severity: Minor
Found in lib/command_definition.rb by rubocop

Use a guard clause instead of wrapping the code inside a conditional expression

Example:

# bad
def test
  if something
    work
  end
end

# good
def test
  return unless something
  work
end

# also good
def test
  work if something
end

# bad
if something
  raise 'exception'
else
  ok
end

# good
raise 'exception' if something
ok

Re-enable Metrics/ClassLength cop with # rubocop:enable after disabling it.
Open

  # rubocop:disable ClassLength
Severity: Minor
Found in lib/command_definition.rb by rubocop

Avoid when branches without a body.
Open

      when RakeCommandFilter::LINE_HANDLING_HIDE_ALWAYS
Severity: Minor
Found in lib/command_definition.rb by rubocop

This cop checks for the presence of when branches without a body.

Example:

# bad

case foo
when bar then 1
when baz then # nothing
end

Example:

# good

case foo
when bar then 1
when baz then 2
end

There are no issues that match your filters.

Category
Status