chrislit/abydos

View on GitHub
abydos/distance/_ratcliff_obershelp.py

Summary

Maintainability
A
2 hrs
Test Coverage

Function sim has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

    def sim(self, src: str, tar: str) -> float:
        """Return the Ratcliff-Obershelp similarity of two strings.

        Parameters
        ----------
Severity: Minor
Found in abydos/distance/_ratcliff_obershelp.py - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Refactor this function to reduce its Cognitive Complexity from 20 to the 15 allowed.
Open

    def sim(self, src: str, tar: str) -> float:

Cognitive Complexity is a measure of how hard the control flow of a function is to understand. Functions with high Cognitive Complexity will be difficult to maintain.

See

Unnecessary elif after return
Open

        if src == tar:

Used in order to highlight an unnecessary block of code following an if containing a return statement. As such, it will warn when it encounters an else following a chain of ifs, all of them containing a return statement.

Unable to import 'numpy'
Open

from numpy import zeros as np_zeros
Severity: Critical
Found in abydos/distance/_ratcliff_obershelp.py by pylint

Used when pylint has been unable to import a module.

Unable to import 'numpy'
Open

from numpy import int_ as np_int
Severity: Critical
Found in abydos/distance/_ratcliff_obershelp.py by pylint

Used when pylint has been unable to import a module.

There are no issues that match your filters.

Category
Status