chrislit/abydos

View on GitHub
abydos/distance/_rouge_w.py

Summary

Maintainability
A
1 hr
Test Coverage

Cyclomatic complexity is too high in method wlcs. (8)
Open

    def wlcs(self, src: str, tar: str) -> float:
        """Return the Rouge-W weighted longest common sub-sequence length.

        Parameters
        ----------
Severity: Minor
Found in abydos/distance/_rouge_w.py by radon

Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

Construct Effect on CC Reasoning
if +1 An if statement is a single decision.
elif +1 The elif statement adds another decision.
else +0 The else statement does not cause a new decision. The decision is at the if.
for +1 There is a decision at the start of the loop.
while +1 There is a decision at the while statement.
except +1 Each except branch adds a new conditional path of execution.
finally +0 The finally block is unconditionally executed.
with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
assert +1 The assert statement internally roughly equals a conditional statement.
Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

Source: http://radon.readthedocs.org/en/latest/intro.html

Function wlcs has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    def wlcs(self, src: str, tar: str) -> float:
        """Return the Rouge-W weighted longest common sub-sequence length.

        Parameters
        ----------
Severity: Minor
Found in abydos/distance/_rouge_w.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Cyclomatic complexity is too high in method sim. (6)
Open

    def sim(self, src: str, tar: str, beta: float = 8) -> float:
        """Return the Rouge-W similarity of two strings.

        Parameters
        ----------
Severity: Minor
Found in abydos/distance/_rouge_w.py by radon

Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

Construct Effect on CC Reasoning
if +1 An if statement is a single decision.
elif +1 The elif statement adds another decision.
else +0 The else statement does not cause a new decision. The decision is at the if.
for +1 There is a decision at the start of the loop.
while +1 There is a decision at the while statement.
except +1 Each except branch adds a new conditional path of execution.
finally +0 The finally block is unconditionally executed.
with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
assert +1 The assert statement internally roughly equals a conditional statement.
Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

Source: http://radon.readthedocs.org/en/latest/intro.html

Unable to import 'numpy'
Open

from numpy import int_ as np_int
Severity: Critical
Found in abydos/distance/_rouge_w.py by pylint

Used when pylint has been unable to import a module.

Parameters differ from overridden 'sim' method
Open

    def sim(self, src: str, tar: str, beta: float = 8) -> float:
Severity: Minor
Found in abydos/distance/_rouge_w.py by pylint

Used when a method has a different number of arguments than in the implemented interface or in an overridden method.

Unable to import 'numpy'
Open

from numpy import zeros as np_zeros
Severity: Critical
Found in abydos/distance/_rouge_w.py by pylint

Used when pylint has been unable to import a module.

Wrong hanging indentation before block (add 4 spaces).
Open

        self,
Severity: Info
Found in abydos/distance/_rouge_w.py by pylint

TODO self, ^ |

Wrong hanging indentation before block (add 4 spaces).
Open

        f_inv: Optional[Callable[[float], float]] = None,
Severity: Info
Found in abydos/distance/_rouge_w.py by pylint

TODO f_inv: Optional[Callable[[float], float]] = None, ^ |

Wrong hanging indentation before block (add 4 spaces).
Open

        **kwargs: Any
Severity: Info
Found in abydos/distance/_rouge_w.py by pylint

TODO **kwargs: Any ^ |

Wrong hanging indentation before block (add 4 spaces).
Open

        f_func: Optional[Callable[[float], float]] = None,
Severity: Info
Found in abydos/distance/_rouge_w.py by pylint

TODO f_func: Optional[Callable[[float], float]] = None, ^ |

Argument name n doesn't conform to snake_case naming style
Open

    def _square(n: float) -> float:
Severity: Info
Found in abydos/distance/_rouge_w.py by pylint

Used when the name doesn't conform to naming rules associated to its type (constant, variable, class...).

Argument name n doesn't conform to snake_case naming style
Open

    def _sqrt(n: float) -> float:
Severity: Info
Found in abydos/distance/_rouge_w.py by pylint

Used when the name doesn't conform to naming rules associated to its type (constant, variable, class...).

There are no issues that match your filters.

Category
Status