Cyclomatic complexity is too high in method stem. (21) Open
def stem(self, word: str) -> str:
"""Return Snowball Norwegian stem.
Parameters
----------- Read upRead up
- Exclude checks
Cyclomatic Complexity
Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.
Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:
| Construct | Effect on CC | Reasoning |
|---|---|---|
| if | +1 | An if statement is a single decision. |
| elif | +1 | The elif statement adds another decision. |
| else | +0 | The else statement does not cause a new decision. The decision is at the if. |
| for | +1 | There is a decision at the start of the loop. |
| while | +1 | There is a decision at the while statement. |
| except | +1 | Each except branch adds a new conditional path of execution. |
| finally | +0 | The finally block is unconditionally executed. |
| with | +1 | The with statement roughly corresponds to a try/except block (see PEP 343 for details). |
| assert | +1 | The assert statement internally roughly equals a conditional statement. |
| Comprehension | +1 | A list/set/dict comprehension of generator expression is equivalent to a for loop. |
| Boolean Operator | +1 | Every boolean operator (and, or) adds a decision point. |
Cyclomatic complexity is too high in class SnowballNorwegian. (21) Open
class SnowballNorwegian(_Snowball):
"""Snowball Norwegian stemmer.
The Snowball Norwegian stemmer is defined at:
http://snowball.tartarus.org/algorithms/norwegian/stemmer.html- Read upRead up
- Exclude checks
Cyclomatic Complexity
Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.
Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:
| Construct | Effect on CC | Reasoning |
|---|---|---|
| if | +1 | An if statement is a single decision. |
| elif | +1 | The elif statement adds another decision. |
| else | +0 | The else statement does not cause a new decision. The decision is at the if. |
| for | +1 | There is a decision at the start of the loop. |
| while | +1 | There is a decision at the while statement. |
| except | +1 | Each except branch adds a new conditional path of execution. |
| finally | +0 | The finally block is unconditionally executed. |
| with | +1 | The with statement roughly corresponds to a try/except block (see PEP 343 for details). |
| assert | +1 | The assert statement internally roughly equals a conditional statement. |
| Comprehension | +1 | A list/set/dict comprehension of generator expression is equivalent to a for loop. |
| Boolean Operator | +1 | Every boolean operator (and, or) adds a decision point. |
Function stem has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring. Open
def stem(self, word: str) -> str:
"""Return Snowball Norwegian stem.
Parameters
----------- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Refactor this function to reduce its Cognitive Complexity from 24 to the 15 allowed. Open
def stem(self, word: str) -> str:- Read upRead up
- Exclude checks
Cognitive Complexity is a measure of how hard the control flow of a function is to understand. Functions with high Cognitive Complexity will be difficult to maintain.
See
Too many branches (18/12) Open
def stem(self, word: str) -> str:- Read upRead up
- Exclude checks
Used when a function or method has too many branches, making it hard to follow.
Too few public methods (1/2) Open
class SnowballNorwegian(_Snowball):- Read upRead up
- Exclude checks
Used when class has too few public methods, so be sure it's really worth it.
Merge this if statement with the enclosing one. Open
if (len(word) > 1 and word[-2] in self._s_endings) or (- Read upRead up
- Exclude checks
Merging collapsible if statements increases the code's readability.
Noncompliant Code Example
if condition1:
if condition2:
# ...
Compliant Solution
if condition1 and condition2:
# ...
Wrong hanging indentation before block (add 4 spaces). Open
'het',- Read upRead up
- Exclude checks
TODO 'het', ^ |
Wrong hanging indentation before block (add 4 spaces). Open
'ane',- Read upRead up
- Exclude checks
TODO 'ane', ^ |
Wrong hanging indentation before block (add 4 spaces). Open
'ets',- Read upRead up
- Exclude checks
TODO 'ets', ^ |
Wrong hanging indentation before block (add 4 spaces). Open
and word[-2] == 'k'- Read upRead up
- Exclude checks
TODO and word[-2] == 'k' ^ |
Wrong hanging indentation before block (add 4 spaces). Open
'ede',- Read upRead up
- Exclude checks
TODO 'ede', ^ |
Wrong hanging indentation before block (add 4 spaces). Open
'ert',- Read upRead up
- Exclude checks
TODO 'ert', ^ |
Wrong hanging indentation before block (add 4 spaces). Open
'ers',- Read upRead up
- Exclude checks
TODO 'ers', ^ |
Wrong hanging indentation before block (add 4 spaces). Open
'ene',- Read upRead up
- Exclude checks
TODO 'ene', ^ |
Wrong hanging indentation before block (add 4 spaces). Open
'ens',- Read upRead up
- Exclude checks
TODO 'ens', ^ |
Wrong hanging indentation before block (add 4 spaces). Open
'ast',- Read upRead up
- Exclude checks
TODO 'ast', ^ |
Wrong hanging indentation before block (add 4 spaces). Open
len(word) > 2- Read upRead up
- Exclude checks
TODO len(word) > 2 ^ |
Wrong hanging indentation before block (add 4 spaces). Open
and word[-3] not in self._vowels- Read upRead up
- Exclude checks
TODO and word[-3] not in self._vowels ^ |